Certificate error pages' contents are no longer vertically centered (content is too far down)

VERIFIED FIXED in Firefox 63

Status

()

defect
VERIFIED FIXED
10 months ago
9 months ago

People

(Reporter: darkspirit, Assigned: trisha)

Tracking

({nightly-community, regression})

Trunk
Firefox 63
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62 unaffected, firefox63 verified)

Details

()

Attachments

(2 attachments)

Debian Testing, KDE, Xorg, GTX 1060, 2560x1440

mozregression --good 2018-07-10 --bad 2018-07-19 -a https://blogs.esa.int/
> 4:44.32 INFO: Last good revision: 53d0bbb455cbe7b28f8303f70f781a98175a8f75
> 4:44.32 INFO: First bad revision: b28ca0001c8e7f30a65cb18e65f750e460a68580
> 4:44.32 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=53d0bbb455cbe7b28f8303f70f781a98175a8f75&tochange=b28ca0001c8e7f30a65cb18e65f750e460a68580

> b28ca0001c8e	Trisha Gupta — Bug 1475025 - Vertically center the various error pages r=johannh

Also check red examples from https://badssl.com/.
Assignee

Updated

10 months ago
Assignee: nobody → guptatrisha97
Status: NEW → ASSIGNED
[clarifying summary to make it clearer how the symptoms here are different from bug 1475025]
Summary: Certificate error pages' contents are no longer vertically centered → Certificate error pages' contents are no longer vertically centered (content is too far down)
Assignee

Comment 2

10 months ago
Attachment #8993592 - Flags: review?(jhofmann)
Comment on attachment 8993592 [details] [diff] [review]
bug1476944.patch

Review of attachment 8993592 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, right, sorry for missing this in my review for bug 1475025 :)

(And thanks to darkspirit for catching this so quickly)
Attachment #8993592 - Flags: review?(jhofmann) → review+
Assignee

Updated

10 months ago
Keywords: checkin-needed

Comment 4

10 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f327edf8970
Vertically center the certificate error pages r=johannh
Keywords: checkin-needed

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3f327edf8970
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
I have reproduced this bug with Nightly 63.0a1 (2018-07-19) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180730100211
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
QA Whiteboard: [bugday-20180725]
Reporter

Updated

10 months ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.