Closed Bug 1476959 Opened Last year Closed Last year

[Win] Cut off tail letters in New Tab page (Highlights section)

Categories

(Firefox :: New Tab Page, defect, P1)

All
Windows
defect

Tracking

()

VERIFIED FIXED
Firefox 63
Iteration:
63.3 - Aug 6
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified
firefox63 --- verified

People

(Reporter: Anca, Assigned: rrosario)

References

Details

(Keywords: regression)

User Story

https://github.com/mozilla/activity-stream/compare/firefox-62b16...c88a5f2ce5e165933e802fcef35a5e045e218302

Attachments

(2 files, 1 obsolete file)

Attached image screenshot issue.png
[Affected versions]: 
- 62.0b9 (20180713213322))
- 63.0a1 (2018-07-19

[Affected platforms]:
- Windows 10 x64
- Windows 7 x32

[Steps to reproduce]:
1. Bookmark https://www.facebook.com/
2. Open a new tab
3. Observe the “g” and “p” letters inside the Highlights section

[Expected result]:
- No character is cut off

[Actual result]:
- ”g” and “p” letters are cut off 

[Regression range]: 
- Last good revision: 486bd3917deebcf6e1120859b111d200142d444d
  First bad revision: c9ae7e47a6eff9aef6a691c638754d2f176ee0ad
  Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=486bd3917deebcf6e1120859b111d200142d444d&tochange=c9ae7e47a6eff9aef6a691c638754d2f176ee0ad

[Additional Notes]:
- Mac and Ubuntu platforms are not affected
- This behavior occurs for every website that contains tail letters in their names
Assignee: nobody → rrosario
Iteration: --- → 63.3 - Aug 6
Priority: -- → P1
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/97f3e1b8a6693a1709b61625ad9ff5f10de92095
Fix Bug 1476959 - Cut off tail letters in New Tab page (Highlights section)

https://github.com/mozilla/activity-stream/commit/79ad9779b73d51edf9f7d5a2b27628f0b3573a88
Merge pull request #4258 from rlr/bug1476959/title-text-cutoff

Fix Bug 1476959 - Cut off tail letters in New Tab page (Highlights section)
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Blocks: 1478144
Is this something we should consider for Beta backport?
Flags: needinfo?(rrosario)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Is this something we should consider for Beta backport?

Sounds good to me!

:Mardak, shall we do an export for uplift?
Flags: needinfo?(rrosario) → needinfo?(edilee)
Ricky, did this end up landing in beta 62?
Flags: needinfo?(rrosario)
No, we've been focused on the top search changes that are targeting 62. We can make an uplift patch today before requesting uplift for the top search stuff.
Flags: needinfo?(rrosario)
Flags: needinfo?(edilee)
User Story: (updated)
Depends on: 1478183
Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Carrying R+ forward from github PR: https://github.com/mozilla/activity-stream/pull/4258

Approval Request Comment
[Feature/Bug causing the regression]: Title in highlight cards are cut off
[User impact if declined]: Poor UI - possibly leading to an unreadable title 
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes (63.0a1)
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just a small CSS adjustment for line height and padding
[String changes made/needed]: None
Attachment #8999719 - Flags: review+
Attachment #8999719 - Flags: approval-mozilla-beta?
Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Ursula Sarracini (:ursula) has been removed from the revision.
Attachment #8999719 - Flags: review+
Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Ed Lee :Mardak (PTO Aug 11-26) has approved the revision.
Attachment #8999719 - Flags: review+
Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Ursula Sarracini (:ursula) has been removed from the revision.
Attachment #8999719 - Flags: review+
Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

CSS fix for new tab page, should be fine to uplift for beta 18.
Attachment #8999719 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
User Story: (updated)
Blocks: 1482398
User Story: (updated)
This issue is fixed on the latest Nightly (63.0a1 - 20180816100035) and latest Beta (62.0b18 - 20180816151750) under Windows platforms.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
See Also: → 1527819
Attachment #8999719 - Attachment is obsolete: true
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.