1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Anca Soncutean, Desktop QA]

Attachment: screenshot issue.png

[Affected versions]: 
- 62.0b9 (20180713213322))
- 63.0a1 (2018-07-19

[Affected platforms]:
- Windows 10 x64
- Windows 7 x32

[Steps to reproduce]:
1. Bookmark https://www.facebook.com/
2. Open a new tab
3. Observe the “g” and “p” letters inside the Highlights section

[Expected result]:
- No character is cut off

[Actual result]:
- ”g” and “p” letters are cut off 

[Regression range]: 
- Last good revision: 486bd3917deebcf6e1120859b111d200142d444d
  First bad revision: c9ae7e47a6eff9aef6a691c638754d2f176ee0ad
  Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=486bd3917deebcf6e1120859b111d200142d444d&tochange=c9ae7e47a6eff9aef6a691c638754d2f176ee0ad

[Additional Notes]:
- Mac and Ubuntu platforms are not affected
- This behavior occurs for every website that contains tail letters in their names

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4258

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/97f3e1b8a6693a1709b61625ad9ff5f10de92095
Fix Bug 1476959 - Cut off tail letters in New Tab page (Highlights section)

https://github.com/mozilla/activity-stream/commit/79ad9779b73d51edf9f7d5a2b27628f0b3573a88
Merge pull request #4258 from rlr/bug1476959/title-text-cutoff

Fix Bug 1476959 - Cut off tail letters in New Tab page (Highlights section)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/ea88051a288d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta backport?

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Is this something we should consider for Beta backport?

Sounds good to me!

:Mardak, shall we do an export for uplift?

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Ricky, did this end up landing in beta 62?

Comment 7

[Ed Lee :Mardak]

No, we've been focused on the top search changes that are targeting 62. We can make an uplift patch today before requesting uplift for the top search stuff.

Comment 8

[Ursula Sarracini (:ursula)]

Attachment: Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Comment 9

[Ursula Sarracini (:ursula)]

Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Carrying R+ forward from github PR: https://github.com/mozilla/activity-stream/pull/4258

Approval Request Comment
[Feature/Bug causing the regression]: Title in highlight cards are cut off
[User impact if declined]: Poor UI - possibly leading to an unreadable title 
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes (63.0a1)
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just a small CSS adjustment for line height and padding
[String changes made/needed]: None

Comment 10

[Ursula Sarracini (:ursula)]

Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Ursula Sarracini (:ursula) has been removed from the revision.

Comment 11

[Ed Lee :Mardak]

Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Ed Lee :Mardak (PTO Aug 11-26) has approved the revision.

Comment 12

[Ursula Sarracini (:ursula)]

Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

Ursula Sarracini (:ursula) has been removed from the revision.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8999719 [details]
Bug 1476959 - [Win] Cut off tail letters in New Tab page (Highlights section)

CSS fix for new tab page, should be fine to uplift for beta 18.

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/edf72394ec67

Comment 15

[Anca Soncutean, Desktop QA]

This issue is fixed on the latest Nightly (63.0a1 - 20180816100035) and latest Beta (62.0b18 - 20180816151750) under Windows platforms.