1476970 - Themes are not applied

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect, P2)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Nokia 9(Android 7.1.1);
Build: Nightly 63.0a1 (2018-07-19);

Steps to reproduce:
1. Go to addons.mozilla.org and select a theme;
2. Choose "Tap to preview";
3. Choose "Install theme".

Expected result:
For step 2 - The theme is applied.
For step 3 - The new theme is installed.

Actual result:
The theme is listed in about:addons but is not applied to the browser. Enabling/disabling the theme doesn't have any action.

Comment 1

[Jan Henning [:JanH]]

Existing themes are still working for me, though.

Additionally,
> 2. Choose "Tap to preview";
I'm no longer seeing that option, but I remember reading somewhere not long ago (can't remember where, though), that that feature would be removed from AMO.

and
> 3. Choose "Install theme".
is working for me as well.

The only problem I see is that the "Install theme" button on AMO doesn't change into an "Uninstall theme" button and instead I have to go to about:addons and uninstall the theme from there. But that is probably an AMO issue and should be filed there.

Comment 2

[Sorina Florean [:sflorean]]

Tested again on Nightly (fresh install)and I was able to reproduce also on the following devices: Google Pixel(Android 9), Oneplus Two(Android 6.0.1), Samsung Galaxy Note 8 (Android 8.0.0). Here is a video: https://drive.google.com/open?id=1IdolvP8LAhXR8926StDeC3qMQnCGA5xF.

Regression window (inbound):
Last good build: a4a611c6
First bad build: bf951826

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a4a611c6bfddb123497976ab7bdbf1fb6eb6b8a3&tochange=bf951826537fdadb6c33cc682f33d4724ba68477

Comment 3

[David Durst [:ddurst]]

Regression window for Tim: do you mind taking a look?

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1476970 - Port desktop LightweightConsumer.jsm changes to Android.

Review commit: https://reviewboard.mozilla.org/r/259638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259638/

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8995161 [details]
Bug 1476970 - Port desktop LightweightConsumer.jsm changes to Android.

https://reviewboard.mozilla.org/r/259638/#review266714

I'm not a great person to review this, but I'm not sure who else is better, so my stamp will do.  Thanks, Tim!  JanH -- if you want to spot check this, please correct me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f55fa458f34f
Port desktop LightweightConsumer.jsm changes to Android. r=nalexander

Comment 7

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f55fa458f34f

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed in build 63.0a1 (2018-07-29).
Devices: Nokia 9(Android 7.1.1), Samsung Galaxy Note8(Android 8.0);