Closed Bug 1476975 Opened 6 years ago Closed 6 years ago

Fix handling of AV1 pref

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla63

Tracking Flags:

Tracking

Status

firefox63

---

fixed

People

(Reporter: dminor, Assigned: jya)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(3 files)

Bug 1476975 - P1. Make media.av1.enabled pref public. 6 years ago Jean-Yves Avenard [:jya] 59 bytes, text/x-review-board-request	dminor : review+	Details
Bug 1476975 - P2. Add mochitests. 6 years ago Jean-Yves Avenard [:jya] 59 bytes, text/x-review-board-request	dminor : review+	Details
Bug 1476975 - P3. Fix canPlayType/isTypeSupported for AV1 content. 6 years ago Jean-Yves Avenard [:jya] 59 bytes, text/x-review-board-request	dminor : review+	Details

Dan Minor [:dminor]

Reporter

Description

•

6 years ago

Currently the media.av1.enabled pref is not checked by canPlayType and IsTypeSupported, so we report support for av1 even when it is disabled by the pref.

We'd also like to enable av1 for all builds, not just nightly builds, controlled by the pref.

Jean-Yves Avenard [:jya]

Assignee

Comment 1

•

6 years ago

canPlayType(“video/webm; codecs=\“av1\”); will always report probably, even when the pref is disabled, when it will cause a playback decoding error if it is.

canPlayType(“video/mp4; codecs=\”av1\”); will either report “probably” or “” depending on the pref being set, when this will never play correctly…

AV1 in mp4 can't work, see bug 1417050

Updated

•

6 years ago

URL: https://jyavenard.github.io/htmltests...

Nils Ohlmeier [:drno]

Updated

•

6 years ago

Rank: 15

Priority: -- → P2

Comment hidden (mozreview-request)

Makes it easier to toggle for tests.

Review commit: https://reviewboard.mozilla.org/r/258296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258296/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/258298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258298/

Comment hidden (mozreview-request)

AV1 support is behind a pref, as such, the result of canPlayType should depends on the value of that pref.

Additionally to this change we remove AOMDecoder::IsSupportedCodec as it implied confusion on what a codec mimetype is. There are two type of codec mimetype: the one describing the container content ("av1") and the one describing the codec itself "video/av1")
AOMDecoder shouldn't know anything about containers (e.g. mp4 or webm)

Review commit: https://reviewboard.mozilla.org/r/258300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258300/

Jean-Yves Avenard [:jya]

Assignee

Comment 5

•

6 years ago

my bad, didn't see that you assigned it to yourself.

Dan Minor [:dminor]

Reporter

Comment 6

•

6 years ago

mozreview-review

Comment on attachment 8993603 [details]
Bug 1476975 - P1. Make media.av1.enabled pref public.

https://reviewboard.mozilla.org/r/258296/#review265382

Attachment #8993603 - Flags: review?(dminor) → review+

Dan Minor [:dminor]

Reporter

Comment 7

•

6 years ago

mozreview-review

Comment on attachment 8993604 [details]
Bug 1476975 - P2. Add mochitests.

https://reviewboard.mozilla.org/r/258298/#review265384

Attachment #8993604 - Flags: review?(dminor) → review+

Dan Minor [:dminor]

Reporter

Comment 8

•

6 years ago

mozreview-review

Comment on attachment 8993605 [details]
Bug 1476975 - P3. Fix canPlayType/isTypeSupported for AV1 content.

https://reviewboard.mozilla.org/r/258300/#review265386

Attachment #8993605 - Flags: review?(dminor) → review+

Dan Minor [:dminor]

Reporter

Updated

•

6 years ago

Assignee: dminor → jyavenard

Pulsebot

Comment 9

•

6 years ago

Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5377ceef34f
P1. Make media.av1.enabled pref public. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/798f4894ffd5
P2. Add mochitests. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/91585d095420
P3. Fix canPlayType/isTypeSupported for AV1 content. r=dminor

Noemi Erli[:noemi_erli]

Comment 10

•

6 years ago

Backed out 3 changesets (bug 1476975) for mochitest failures on test_can_play_type_webm.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=91585d0954201387ccd156957b48c13393ec0788&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=189229161

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=189229161&repo=mozilla-inbound&lineNumber=1127

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/56d2f39f9e2968f96b3d2bbd587952447e5993de

Flags: needinfo?(jyavenard)

Comment hidden (mozreview-request)

Comment on attachment 8993603 [details]
Bug 1476975 - P1. Make media.av1.enabled pref public.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258296/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8993604 [details]
Bug 1476975 - P2. Add mochitests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258298/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8993605 [details]
Bug 1476975 - P3. Fix canPlayType/isTypeSupported for AV1 content.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258300/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8993603 [details]
Bug 1476975 - P1. Make media.av1.enabled pref public.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258296/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8993604 [details]
Bug 1476975 - P2. Add mochitests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258298/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8993605 [details]
Bug 1476975 - P3. Fix canPlayType/isTypeSupported for AV1 content.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258300/diff/2-3/

Mozilla Autoland

Comment 17

•

6 years ago

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7decdccf86d062f43fbad9b7314a02958df11b0e -d 3bbf774e9e48: rebasing 473802:7decdccf86d0 "Bug 1476975 - P1. Make media.av1.enabled pref public. r=dminor"
rebasing 473803:0d862ca7c5ee "Bug 1476975 - P2. Add mochitests. r=dminor"
merging dom/media/test/test_can_play_type_mpeg.html
warning: conflicts while merging dom/media/test/test_can_play_type_mpeg.html! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Jean-Yves Avenard [:jya]

Assignee

Comment 18

•

6 years ago

Dan could you please rebase and push please? I have no mean to do so for the next two weeks. Thank you

Flags: needinfo?(jyavenard) → needinfo?(dminor)

Pulsebot

Comment 19

•

6 years ago

Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6863cbce8a83
P1. Make media.av1.enabled pref public. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/042c51e269bf
P2. Add mochitests. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/32bdeb5086b0
P3. Fix canPlayType/isTypeSupported for AV1 content. r=dminor

Dan Minor [:dminor]

Reporter

Comment 20

•

6 years ago

Will do.

Flags: needinfo?(dminor)

Cristina Coroiu [:ccoroiu]

Comment 21

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/6863cbce8a83
https://hg.mozilla.org/mozilla-central/rev/042c51e269bf
https://hg.mozilla.org/mozilla-central/rev/32bdeb5086b0

Status: ASSIGNED → RESOLVED

Closed: 6 years ago

status-firefox63: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla63

Raul Gurzau (:RaulG)

Updated

•

6 years ago

Depends on: 1478005

You need to log in before you can comment on or make changes to this bug.