Closed Bug 1476975 Opened 4 years ago Closed 4 years ago

Fix handling of AV1 pref

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

63 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dminor, Assigned: jya)

References

(Blocks 1 open bug, )

Details

Attachments

(3 files)

Currently the media.av1.enabled pref is not checked by canPlayType and IsTypeSupported, so we report support for av1 even when it is disabled by the pref.

We'd also like to enable av1 for all builds, not just nightly builds, controlled by the pref.
canPlayType(“video/webm; codecs=\“av1\”); will always report probably, even when the pref is disabled, when it will cause a playback decoding error if it is.

canPlayType(“video/mp4; codecs=\”av1\”); will either report “probably” or “” depending on the pref being set, when this will never play correctly…

AV1 in mp4 can't work, see bug 1417050
See Also: → 1417050
Rank: 15
Priority: -- → P2
my bad, didn't see that you assigned it to yourself.
Comment on attachment 8993603 [details]
Bug 1476975 - P1. Make media.av1.enabled pref public.

https://reviewboard.mozilla.org/r/258296/#review265382
Attachment #8993603 - Flags: review?(dminor) → review+
Comment on attachment 8993604 [details]
Bug 1476975 - P2. Add mochitests.

https://reviewboard.mozilla.org/r/258298/#review265384
Attachment #8993604 - Flags: review?(dminor) → review+
Comment on attachment 8993605 [details]
Bug 1476975 - P3. Fix canPlayType/isTypeSupported for AV1 content.

https://reviewboard.mozilla.org/r/258300/#review265386
Attachment #8993605 - Flags: review?(dminor) → review+
Assignee: dminor → jyavenard
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5377ceef34f
P1. Make media.av1.enabled pref public. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/798f4894ffd5
P2. Add mochitests. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/91585d095420
P3. Fix canPlayType/isTypeSupported for AV1 content. r=dminor
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7decdccf86d062f43fbad9b7314a02958df11b0e -d 3bbf774e9e48: rebasing 473802:7decdccf86d0 "Bug 1476975 - P1. Make media.av1.enabled pref public. r=dminor"
rebasing 473803:0d862ca7c5ee "Bug 1476975 - P2. Add mochitests. r=dminor"
merging dom/media/test/test_can_play_type_mpeg.html
warning: conflicts while merging dom/media/test/test_can_play_type_mpeg.html! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Dan could you please rebase and push please? I have no mean to do so for the next two weeks. Thank you
Flags: needinfo?(jyavenard) → needinfo?(dminor)
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6863cbce8a83
P1. Make media.av1.enabled pref public. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/042c51e269bf
P2. Add mochitests. r=dminor
https://hg.mozilla.org/integration/mozilla-inbound/rev/32bdeb5086b0
P3. Fix canPlayType/isTypeSupported for AV1 content. r=dminor
Will do.
Flags: needinfo?(dminor)
Depends on: 1478005
You need to log in before you can comment on or make changes to this bug.