Closed Bug 1476989 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12067 - HTMLAnchorElement::href and HTMLAreaElement::href changed to accept Trusted Types

Categories

(Core :: DOM: Security, enhancement, P4)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog]) 

Sync web-platform-tests PR 12067 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12067
Details from upstream follow.

Maja Kabus <kabusm@google.com> wrote:
>  HTMLAnchorElement::href and HTMLAreaElement::href changed to accept Trusted Types
>  
>  Existing implementation of setHref moved from DOMURLUtils
>  to DOMURL
>  New implementation of setHref added to DOMURLUtils
>  New implementations of href() added to DOMURLUtilsReadOnly
>  to accept URLString as an argument
>  
>  Bug: 739170
>  Change-Id: I047d6a564e65a3be78436faef8780f60b85e8f7c
>  Reviewed-on: https://chromium-review.googlesource.com/1143391
>  WPT-Export-Revision: 385ca73e4b1c0097861ecb5b3e9772c917390b18
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Ran 4 tests and 12 subtests
OK     : 4
FAIL   : 12

New tests that have failures or other problems:
/trusted-types/HTMLAnchorElement-href.tentative.html
    a.href = URLS.safe, TrustedURL.create: FAIL
    a.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
/trusted-types/HTMLAreaElement-href.tentative.html
    area.href = URLS.safe, TrustedURL.create: FAIL
    area.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
/trusted-types/block-string-assignment-to-HTMLAnchorElement-href.tentative.html
    `a.href = null` throws: FAIL
    `a.href = string` throws: FAIL
    a.href = URLS.safe, TrustedURL.create: FAIL
    a.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
/trusted-types/block-string-assignment-to-HTMLAreaElement-href.tentative.html
    `area.href = null` throws: FAIL
    `area.href = string` throws: FAIL
    area.href = URLS.safe, TrustedURL.create: FAIL
    area.href = URLS.safe, TrustedURL.unsafelyCreate: FAIL
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/51ca5b63e278
[wpt PR 12067] - HTMLAnchorElement::href and HTMLAreaElement::href changed to accept Trusted Types, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d50b2bb377a
[wpt PR 12067] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/51ca5b63e278
https://hg.mozilla.org/mozilla-central/rev/6d50b2bb377a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.