Closed
Bug 1477019
Opened 6 years ago
Closed 6 years ago
wasm ion: don't generate dead code for saturating instructions on x86
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(1 file)
|
6.75 KB,
patch
|
sunfish
:
review+
|
Details | Diff | Splinter Review |
There's a RAII class AutoHandleWasmTruncateToIntErrors on x86 that generates two traps and associates two labels to jump to these trap locations. These two labels are unused in the case of the saturating conversions, so we don't need to generate them.
Attachment #8993421 -
Flags: review?(sunfish)
|
||
Comment 1•6 years ago
|
||
Comment on attachment 8993421 [details] [diff] [review] dead-sat.patch Review of attachment 8993421 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense!
Attachment #8993421 -
Flags: review?(sunfish) → review+
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbb6bc40f93e Don't generate dead code for wasm saturating instructions on x86; r=sunfish
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fbb6bc40f93e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•