Closed Bug 1477146 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 12081 - Fixing Server-Timing header parsing tests

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12081 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12081
Details from upstream follow.

Tom McKee <tommckee@chromium.org> wrote:
>  Fixing Server-Timing header parsing tests
>  
>  The Server-Timing response header is allowed to have a comma-separated
>  list of timing metrics. We have test code that checks that the right
>  number of components get parsed. When there are more components than
>  expected, though, the test code ends up trying to lookup a field from an
>  undefined value. This caused the test runner to bail out and skip
>  subsequent tests.
>  
>  This patch changes the test code to check for an undefined value and
>  skip ahead as needed.
>  
>  Change-Id: I2304424978e3d4634c3508b1fefbba809374950e
>  Reviewed-on: https://chromium-review.googlesource.com/1144200
>  WPT-Export-Revision: 462312f6899e48c73d779f172f53858c4a8f15a7
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 2 tests and 328 subtests
OK     : 2
PASS   : 327
FAIL   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c04548ba3284
[wpt PR 12081] - Fixing Server-Timing header parsing tests, a=testonly
https://hg.mozilla.org/mozilla-central/rev/c04548ba3284
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.