Closed Bug 1477161 Opened 6 years ago Closed 6 years ago

Avoid using reserved identifiers

Categories

(Core :: General, enhancement)

Product:
Core
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox63 --- affected

People

(Reporter: xidorn, Unassigned)

References

(Blocks 1 open bug)

Details

According to the C++ standard:
> Each identifier that contains a double underscore __ or begins with an underscore followed by an uppercase letter is reserved to the implementation for any use.

However, we have many headers use double underscore suffix for the guarding macro.

This cause clang to raise reserve-id-macro warning, which we can fix by simply remove all the suffixes.
... or we can just disable such warning on directories where we use -Wall...
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.