Closed Bug 1477230 Opened Last year Closed Last year

[wpt-sync] Sync PR 12089 - [css-grid] Change how percentage row tracks and gaps are resolved

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12089 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12089
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-grid] Change how percentage row tracks and gaps are resolved
>  
>  The CSSWG decided to change how percentage row tracks and gutters
>  in a grid container with indefinite height are resolved.
>  
>  The CSSWG issues are:
>  * https://github.com/w3c/csswg-drafts/issues/1921
>  * https://github.com/w3c/csswg-drafts/issues/509
>  
>  So far they were resolved as "auto", like it happens with
>  percentage heights in regular blocks. But now they're going to behave
>  similar to what happens in the columns axis, they would be ignored
>  to compute the intrinsic height, but then they'll be resolved against
>  that height.
>  This causes that we need to repeat the track sizing algorithm
>  when we have a grid container with indefinite height
>  that has some percentage rows.
>  
>  JFTR, intent to implement and ship thread:
>  https://groups.google.com/a/chromium.org/d/msg/blink-dev/CJgcT4hR7Rk/58WfZNbWBQAJ
>  
>  BUG=846187
>  TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html
>  TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html
>  
>  Change-Id: I2a1959af6c95e0c47d294580599fdbf9bc432348
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1142409
>  WPT-Export-Revision: d2d74f8f21280c2b52e298f31a2b65e089c43755
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 132 subtests
OK     : 3
PASS   : 16
FAIL   : 116

New tests that have failures or other problems:
/css/css-grid/alignment/grid-content-alignment-second-pass-002.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
    .grid 4: FAIL
    .grid 5: FAIL
    .grid 6: FAIL
    .grid 7: FAIL
    .grid 8: FAIL
/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html
    .grid 100: FAIL
    .grid 101: FAIL
    .grid 102: FAIL
    .grid 104: FAIL
    .grid 105: FAIL
    .grid 106: FAIL
    .grid 107: FAIL
    .grid 108: FAIL
    .grid 11: FAIL
    .grid 110: FAIL
    .grid 111: FAIL
    .grid 112: FAIL
    .grid 113: FAIL
    .grid 114: FAIL
    .grid 116: FAIL
    .grid 117: FAIL
    .grid 118: FAIL
    .grid 119: FAIL
    .grid 12: FAIL
    .grid 120: FAIL
    .grid 14: FAIL
    .grid 15: FAIL
    .grid 17: FAIL
    .grid 18: FAIL
    .grid 2: FAIL
    .grid 20: FAIL
    .grid 21: FAIL
    .grid 23: FAIL
    .grid 24: FAIL
    .grid 25: FAIL
    .grid 26: FAIL
    .grid 27: FAIL
    .grid 28: FAIL
    .grid 29: FAIL
    .grid 3: FAIL
    .grid 30: FAIL
    .grid 31: FAIL
    .grid 32: FAIL
    .grid 33: FAIL
    .grid 34: FAIL
    .grid 35: FAIL
    .grid 36: FAIL
    .grid 37: FAIL
    .grid 38: FAIL
    .grid 39: FAIL
    .grid 40: FAIL
    .grid 41: FAIL
    .grid 42: FAIL
    .grid 43: FAIL
    .grid 44: FAIL
    .grid 45: FAIL
    .grid 46: FAIL
    .grid 47: FAIL
    .grid 48: FAIL
    .grid 49: FAIL
    .grid 5: FAIL
    .grid 50: FAIL
    .grid 51: FAIL
    .grid 52: FAIL
    .grid 53: FAIL
    .grid 54: FAIL
    .grid 55: FAIL
    .grid 56: FAIL
    .grid 57: FAIL
    .grid 58: FAIL
    .grid 59: FAIL
    .grid 6: FAIL
    .grid 60: FAIL
    .grid 61: FAIL
    .grid 62: FAIL
    .grid 63: FAIL
    .grid 64: FAIL
    .grid 65: FAIL
    .grid 66: FAIL
    .grid 67: FAIL
    .grid 68: FAIL
    .grid 69: FAIL
    .grid 70: FAIL
    .grid 71: FAIL
    .grid 72: FAIL
    .grid 74: FAIL
    .grid 75: FAIL
    .grid 76: FAIL
    .grid 77: FAIL
    .grid 78: FAIL
    .grid 8: FAIL
    .grid 80: FAIL
    .grid 81: FAIL
    .grid 82: FAIL
    .grid 83: FAIL
    .grid 84: FAIL
    .grid 86: FAIL
    .grid 87: FAIL
    .grid 88: FAIL
    .grid 89: FAIL
    .grid 9: FAIL
    .grid 90: FAIL
    .grid 92: FAIL
    .grid 93: FAIL
    .grid 94: FAIL
    .grid 95: FAIL
    .grid 96: FAIL
    .grid 98: FAIL
    .grid 99: FAIL
/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html
    .grid 1: FAIL
    .grid 2: FAIL
    .grid 3: FAIL
    .grid 4: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04e49a49f1ea
[wpt PR 12089] - [css-grid] Change how percentage row tracks and gaps are resolved, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7389a33caea
[wpt PR 12089] - Update wpt metadata, a=testonly
Backed out 16 changesets (bug 1481478, bug 1482434, bug 1477230, bug 1459618, bug 1460281, bug 1450151, bug 1480787, bug 1480724, bug 1459593, bug 1480560) for wpt failures on multipefiles. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=193473321&repo=mozilla-inbound

INFO - TEST-UNEXPECTED-PASS | /svg/painting/reftests/markers-orient-001.svg | expected FAIL
19:42:55     INFO - TEST-INFO expected FAIL | took 252ms
19:42:55     INFO - PID 5788 | 1534016575691	Marionette	INFO	Stopped listening on port 2828
19:42:55     INFO - PID 5788 | [Child 1260, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 1260, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4120, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4120, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Parent 5788, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4888, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4888, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Parent 5788, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 188
19:42:56     INFO - Browser exited with return code 0
19:42:56  WARNING - u'runner_teardown': ()
19:42:56     INFO - Setting up ssl
19:42:56     INFO - certutil | 
19:42:56     INFO - certutil | 
19:42:56     INFO - certutil | 
19:42:56     INFO - Certificate Nickname                                         Trust Attributes
19:42:56     INFO -                                                              SSL,S/MIME,JAR/XPI
19:42:56     INFO - 
19:42:56     INFO - web-platform-tests      

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=16c9abfa230cd3fe48e7772022c7a2fe70a314be

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de68b04194643a337a75616de65dbd76979846c2
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b695a1526020
[wpt PR 12089] - [css-grid] Change how percentage row tracks and gaps are resolved, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a56d67a01d2d
[wpt PR 12089] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/b695a1526020
https://hg.mozilla.org/mozilla-central/rev/a56d67a01d2d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.