mach help doesn't work without an objdir

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: bhearsum, Assigned: ahal)

Tracking

Trunk
mozilla63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

For example:
➜  unified hg status
➜  unified hg ident
4f12d77b4f9b tip
➜  unified ./mach help
Error running mach:

    ['help']

The error occurred in mach itself. This is likely a bug in mach itself or a
fundamental problem with a loaded module.

Please consider filing a bug against mach by going to the URL:

    https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox%20Build%20System&component=Mach%20Core


If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

BuildEnvironmentNotFoundException: config.status not available. Run configure.

  File "/home/bhearsum/repos/unified/python/mach/mach/main.py", line 359, in run
    return self._run(argv)
  File "/home/bhearsum/repos/unified/python/mach/mach/main.py", line 414, in _run
    args = parser.parse_args(argv)
  File "/usr/lib/python2.7/argparse.py", line 1701, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1733, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1942, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/usr/lib/python2.7/argparse.py", line 1898, in consume_positionals
    take_action(action, args)
  File "/usr/lib/python2.7/argparse.py", line 1807, in take_action
    action(self, namespace, argument_values, option_string)
  File "/home/bhearsum/repos/unified/python/mach/mach/dispatcher.py", line 112, in __call__
    self._handle_main_help(parser, namespace.verbose)
  File "/home/bhearsum/repos/unified/python/mach/mach/dispatcher.py", line 264, in _handle_main_help
    if not c(instance):
  File "/home/bhearsum/repos/unified/testing/mach_commands.py", line 339, in has_binary
    name = binary + cls.substs['BIN_SUFFIX']
  File "/home/bhearsum/repos/unified/python/mozbuild/mozbuild/base.py", line 253, in substs
    return self.config_environment.substs
  File "/home/bhearsum/repos/unified/python/mozbuild/mozbuild/base.py", line 236, in config_environment
    raise BuildEnvironmentNotFoundException('config.status not available. Run configure.')
Assignee

Updated

11 months ago
Assignee: nobody → ahal
Status: NEW → ASSIGNED
Comment on attachment 8993691 [details]
Bug 1477276 - Fix regression preventing |mach help| without an objdir

Ben Hearsum (:bhearsum) has approved the revision.

https://phabricator.services.mozilla.com/D2267
Attachment #8993691 - Flags: review+

Comment 3

11 months ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ece31a9e0c0b
Fix regression preventing |mach help| without an objdir r=bhearsum

Comment 4

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ece31a9e0c0b
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.