Closed
Bug 1477277
Opened 6 years ago
Closed 6 years ago
Poorly visible tracking protection tour text on dark theme
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | unaffected |
firefox61 | --- | wontfix |
firefox62 | --- | verified |
firefox63 | --- | verified |
People
(Reporter: ntim, Assigned: ntim)
References
Details
(Keywords: regression)
Attachments
(3 files)
77.99 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
johannh
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
78.02 KB,
image/png
|
Details |
STR: - Enable dark theme - Visit https://www.mozilla.org/en-GB/firefox/63.0a1/tracking-protection/start/?step=1 AR: "1 of 3" is poorly visible
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8993694 [details] Bug 1477277 - Use panel CSS variables instead of hardcoded colors for UITour panel. https://reviewboard.mozilla.org/r/258378/#review265480 Thanks!
Attachment #8993694 -
Flags: review?(jhofmann) → review+
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/216188a67567 Use panel CSS variables instead of hardcoded colors for UITour panel. r=johannh
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/216188a67567
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Assignee | ||
Comment 6•6 years ago
|
||
Comment on attachment 8993694 [details] Bug 1477277 - Use panel CSS variables instead of hardcoded colors for UITour panel. Approval Request Comment [Feature/Bug causing the regression]: bug 1408121 [User impact if declined]: See comment 0 [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: see comment 0 [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: low risk [Why is the change risky/not risky?]: css only [String changes made/needed]: no
Attachment #8993694 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•6 years ago
|
status-firefox61:
--- → wontfix
status-firefox62:
--- → affected
Updated•6 years ago
|
Keywords: regression
Comment 7•6 years ago
|
||
Comment on attachment 8993694 [details] Bug 1477277 - Use panel CSS variables instead of hardcoded colors for UITour panel. Fix for text visibility for new onboarding, let's uplift to beta.
Attachment #8993694 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•6 years ago
|
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Comment 8•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/c3726dae9f06
Updated•6 years ago
|
Flags: qe-verify+
Comment 9•6 years ago
|
||
I managed to reproduce the bug using an older version of Nightly (2018-07-20) on Windows 10 x64. I retested using Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.12 on latest Nightly 63.0a1 and beta 62.0b12. The bug is not reproducing anymore. The numbers can be seen clearly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•