1477277 - Poorly visible tracking protection tour text on dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Attachment: Screenshot 2018-07-20 at 15.37.17.png

STR:
- Enable dark theme
- Visit https://www.mozilla.org/en-GB/firefox/63.0a1/tracking-protection/start/?step=1


AR:
"1 of 3" is poorly visible

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1477277 - Use panel CSS variables instead of hardcoded colors for UITour panel.

Review commit: https://reviewboard.mozilla.org/r/258378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258378/

Comment 2

[Tim Nguyen :ntim]

Attachment: Screenshot of patch

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8993694 [details]
Bug 1477277 - Use panel CSS variables instead of hardcoded colors for UITour panel.

https://reviewboard.mozilla.org/r/258378/#review265480

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/216188a67567
Use panel CSS variables instead of hardcoded colors for UITour panel. r=johannh

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/216188a67567

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8993694 [details]
Bug 1477277 - Use panel CSS variables instead of hardcoded colors for UITour panel.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1408121
[User impact if declined]: See comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: see comment 0
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: css only
[String changes made/needed]: no

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8993694 [details]
Bug 1477277 - Use panel CSS variables instead of hardcoded colors for UITour panel.

Fix for text visibility for new onboarding, let's uplift to beta.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c3726dae9f06

Comment 9

[Oana Botisan, Desktop QA]

I managed to reproduce the bug using an older version of Nightly (2018-07-20) on Windows 10 x64.
I retested using Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.12 on latest Nightly 63.0a1 and beta 62.0b12. The bug is not reproducing anymore. The numbers can be seen clearly.