1477310 - Enable the new certificate error pages by default in Nightly

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P1)

Comment 1

[Trisha Gupta [:trisha]]

Attachment: Bug 1477310 - Enable the new certificate error pages by default in Nightly

Review commit: https://reviewboard.mozilla.org/r/260748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260748/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8996658 [details]
Bug 1477310 - Enable the new certificate error pages by default in Nightly

https://reviewboard.mozilla.org/r/260748/#review268188

Thanks!

::: browser/app/profile/firefox.js:986
(Diff revision 1)
>  pref("app.productInfo.baseURL", "https://www.mozilla.org/firefox/features/");
>  
>  // Name of alternate about: page for certificate errors (when undefined, defaults to about:neterror)
>  pref("security.alternate_certificate_error_page", "certerror");
>  
> -// Indicates if new certificate error page (enabled) or not
> +// Enable the new certificate error page only for Nightly: Bug 1477310

nit: we usually don't reference bugs that have done things in the past, this is more commonly done for TODO items etc.

Comment 3

[Trisha Gupta [:trisha]]

Comment on attachment 8996658 [details]
Bug 1477310 - Enable the new certificate error pages by default in Nightly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260748/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5240a6344b28
Enable the new certificate error pages by default in Nightly r=johannh

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 5240a6344b28 (bug 1477310) for browser-chrome failures at browser/base/content/test/about/browser_aboutCertError.js

Backout: https://hg.mozilla.org/integration/autoland/rev/f9959fba65defa7d4c9a5d4dfa7bbfca6cc2494f

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5240a6344b28a1d9d8b9df08c17b63bb54926122

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191890136&repo=autoland&lineNumber=1446

[task 2018-08-03T16:04:33.748Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Exception button is hidden - 
[task 2018-08-03T16:04:33.748Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Didn't find SSL_ERROR_BAD_CERT_DOMAIN. - 
[task 2018-08-03T16:04:33.750Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Didn't find error message. - 
[task 2018-08-03T16:04:33.751Z] 16:04:33     INFO - Buffered messages finished
[task 2018-08-03T16:04:33.751Z] 16:04:33     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutCertError.js | Didn't find error message. - 
[task 2018-08-03T16:04:33.752Z] 16:04:33     INFO - Stack trace:
[task 2018-08-03T16:04:33.753Z] 16:04:33     INFO - chrome://mochitests/content/browser/browser/base/content/test/about/browser_aboutCertError.js:checkBadStsCert:158
[task 2018-08-03T16:04:33.754Z] 16:04:33     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
[task 2018-08-03T16:04:33.756Z] 16:04:33     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
[task 2018-08-03T16:04:33.756Z] 16:04:33     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
[task 2018-08-03T16:04:33.757Z] 16:04:33     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-08-03T16:04:33.759Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Didn't find domain in error message. - 
[task 2018-08-03T16:04:33.759Z] 16:04:33     INFO - Loading cert error page in an iframe
[task 2018-08-03T16:04:33.880Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Exception button is hidden - 
[task 2018-08-03T16:04:33.899Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Didn't find SSL_ERROR_BAD_CERT_DOMAIN. - 
[task 2018-08-03T16:04:33.901Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Didn't find error message. - 
[task 2018-08-03T16:04:33.902Z] 16:04:33     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-08-03T16:04:33.903Z] 16:04:33     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutCertError.js | Didn't find error message. - 
[task 2018-08-03T16:04:33.904Z] 16:04:33     INFO - Stack trace:
[task 2018-08-03T16:04:33.906Z] 16:04:33     INFO - chrome://mochitests/content/browser/browser/base/content/test/about/browser_aboutCertError.js:checkBadStsCert:158
[task 2018-08-03T16:04:33.907Z] 16:04:33     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
[task 2018-08-03T16:04:33.908Z] 16:04:33     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
[task 2018-08-03T16:04:33.909Z] 16:04:33     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
[task 2018-08-03T16:04:33.910Z] 16:04:33     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-08-03T16:04:33.912Z] 16:04:33     INFO - TEST-PASS | browser/base/content/test/about/browser_aboutCertError.js | Didn't find domain in error message. - 
[task 2018-08-03T16:04:33.921Z] 16:04:33     INFO - Leaving test bound checkBadStsCert

Comment 6

[Trisha Gupta [:trisha]]

Attachment: bug1477310.patch

The mochitest works for me now, I've submitted it for a try run too. Can you please review the amended patch just to be sure? Thank you.

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8999159 [details] [diff] [review]
bug1477310.patch

Review of attachment 8999159 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/385ebda7ee53
Enable the new certificate error pages by default in Nightly. r=johannh

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/385ebda7ee53