1477332 - add aarch64 to mozinfo's known list of 64-bit cpus

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add aarch64 to mozinfo's known list of 64-bit cpus

Might as well.

Comment 2

[(Away)]

Comment on attachment 8993759 [details] [diff] [review]
add aarch64 to mozinfo's known list of 64-bit cpus

Review of attachment 8993759 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mozinfo.py
@@ +64,5 @@
>      if p.startswith("arm"):
>          p = "arm"
>      elif re.match("i[3-9]86", p):
>          p = "x86"
>      d["processor"] = p

This would leave `d["processor"]` as `aarch64`. Is that desired? Or should we make it `arm`? (Genuinely wondering; I don't know what the answer should be.)

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to David Major [:dmajor] from comment #2)
> Comment on attachment 8993759 [details] [diff] [review]
> add aarch64 to mozinfo's known list of 64-bit cpus
> 
> Review of attachment 8993759 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: python/mozbuild/mozbuild/mozinfo.py
> @@ +64,5 @@
> >      if p.startswith("arm"):
> >          p = "arm"
> >      elif re.match("i[3-9]86", p):
> >          p = "x86"
> >      d["processor"] = p
> 
> This would leave `d["processor"]` as `aarch64`. Is that desired? Or should
> we make it `arm`? (Genuinely wondering; I don't know what the answer should
> be.)

`aarch64`.startswith(`arm`) is False, so I think that's the desired behavior.  They are two separate architectures, after all.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/165ba091863c
add aarch64 to mozinfo's known list of 64-bit cpus; r=chmanchester

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/165ba091863c