1477343 - content process isParentWindowMainWidgetVisible implementation seems to be dead code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

I think this was added in bug 899648.

TabParent::RecvIsParentWindowMainWidgetVisible would crash if called as of today (because windows don't QI to nsIDOMWindowUtils and then we'd get a null-deref).  But it's never called, because the only consumer of isParentWindowMainWidgetVisible is in nsPrompter.js in openModalWindow, which is only called in the parent process.

Can we just remove the IPC bits here and have nsDOMWindowUtils::GetIsParentWindowMainWidgetVisible throw or return false or crash when called in a child process?

Note that bug 1476145 will change TabParent to code that doesn't crash, but it's still dead code.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Yeah, we can just remove this (and kill the sync message while we're at it).

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1477343 - Remove PBrowser::IsParentWindowMainWidgetVisible. r=bz

Comment 3

[Phabricator Automation]

Comment on attachment 8994715 [details]
Bug 1477343 - Remove PBrowser::IsParentWindowMainWidgetVisible. r=bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2347

Comment 4

[Phabricator Automation]

Comment on attachment 8994715 [details]
Bug 1477343 - Remove PBrowser::IsParentWindowMainWidgetVisible. r=bz

Andrew McCreight [:mccr8] has approved the revision.

https://phabricator.services.mozilla.com/D2347

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b9fac2e27ef
Remove PBrowser::IsParentWindowMainWidgetVisible. r=mccr8,bzbarsky

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2b9fac2e27ef