Closed
Bug 1477351
Opened 6 years ago
Closed 6 years ago
richlistitems in Preferences Attachments pane have too much padding
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 63.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
|
4.08 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Since bug 1475816 the attachments richlistitems have too much padding.
|
Assignee | |
Comment 1•6 years ago
|
||
This fixes the padding issue on all platforms. I also changed the shortDetails colour to be also readable when the richlistitem is selected.
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8993771 [details] [diff] [review] attachmentPadding.patch Also nice. However, there is one issue. If the richlist of apps loses focus because you click into the search box above, then the selection colour stays. That wasn't like this before. I think the selection colour should be dimmed (or similar) to indicate that the control doesn't have focus. Is that possible? How does it look in FF Nightly?
Attachment #8993771 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Good catch. This should be better.
Attachment #8993771 -
Attachment is obsolete: true
Attachment #8993774 -
Flags: review?(jorgk)
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8993774 [details] [diff] [review] attachmentPadding.patch I'll have this one ;-)
Attachment #8993774 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/5b2f9301c7a9 Fix the "Preferences > Attachments" richlistitem padding. r=jorgk
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 63.0
You need to log in
before you can comment on or make changes to this bug.
Description
•