1477367 - Pressing F1 in open meatball door-hanger menu does not close the menu

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[Abe - QA (:Abe_LV)]

Steps to reproduce:
1. Open door-hanger menu
2. Press F1
3. Observe: Settings open
4. Press F1 again
5. Observe: the door-hanger menu is still open
6. Click Settings menu item
7. Observe: the menu is closes

Expected Result:
Door-hanger menu should be closed once settings menu is opened.

Actual Result:
Pressing F1 does not close the door-hanger menu. The user needs additional action to close the menu. 
Clicking the [Settings] menu item closes the door-hanger menu, which is good.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

We can prevent this by handling the F1 key in menu button.

WIP: https://hg.mozilla.org/try/rev/44053c25c0ef9dd8c51bee83bc4b41b24d2d58ef

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

I think that the MenuButton needs to independent from devtools implementation and closing the menu with the F1 key is based on the devtools specification.
So I updated the patch to close the popup menu via event emitter. If other operations need to close the menu, we can use this emit the event. (e.g., Ctrl + Shift + S will open the debugger panel. If we open the meatball menu and press this shortcut, devtools doesn't close the meatball menu at the moment. So we can use this event in this case.)

WIP: https://hg.mozilla.org/try/rev/06f1791e627eb204e3ab42b332ae3bf76b327c16

The chevron menu creates the component when changing the panel, so I think that we don't need to apply it to the chevron menu at the moment.

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1477367 - Close the popup menu before changing the panel to options panel. r?birtles

Pressing the F1 key make the toolbox panel to options panel, However, popup menu
doesn't closed at the moment. This patch will close the popup menu in this case.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8998383 [details]
Bug 1477367 - Close the popup menu before changing the panel to options panel. r?birtles

Brian Birtles (:birtles) has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5569f1c67c0
Close the popup menu before changing the panel to options panel. r=birtles

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a5569f1c67c0

Comment 7

[Abe - QA (:Abe_LV)]

I tested this on mac, windows, and Ubuntu with the latest nightly. F1 key is working as intended. So this is verified as fixed.