Closed
Bug 1477375
Opened 6 years ago
Closed 6 years ago
Ensure we actually disable all CacheIR Stubs when requested with --cache-ir-stubs=off
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
Details
Attachments
(1 file)
|
1.40 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
While investigating Bug 1476417 I discovered that --cache-ir-stubs=off doesn't catch all caches attachment attempts.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8993777 -
Flags: review?(evilpies)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8993777 [details] [diff] [review] Ensure we actually disable all CacheIR Stubs when requested with --cache-ir-stubs=off Thanks for looking into that. Seems like we need to do this for this case only, because this IC is not fully converted to CacheIR yet. Everywhere else is handled by `ic->state().canAttachStub()`.
Attachment #8993777 -
Flags: review?(evilpies) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/16f5d9f58faa Ensure we actually disable all CacheIR Stubs when requested with --cache-ir-stubs=off. r=evilpie
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/16f5d9f58faa
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•