Closed Bug 1477455 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 12115 - Clean up picture-in-picture tests

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12115 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12115
Details from upstream follow.

Luke Bjerring <lukebjerring@google.com> wrote:
>  Clean up picture-in-picture tests
>  
>  Simplifies the IDL test (now that it supports async/promises in the setup function).
>  Removes the redundant `callWithTrustedClick` method in favor of the almost-identical `test_driver.bless` method.
>  
>  Chrome 69:
>  Ran 76 checks (10 tests, 66 subtests)
>  Expected results: 76
PR 12115 applied with additional changes from upstream: ab9fce0c39c50afa4e6bb51b1cabfe4ffccc2bf8, f9e7716a09467b9e1d0146e5bc1952375c08506f, 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356
Ran 10 tests and 66 subtests
OK     : 10
PASS   : 15
FAIL   : 51

New tests that have failures or other problems:
/picture-in-picture/idlharness.window.html
    DocumentOrShadowRoot interface: document must inherit property "pictureInPictureElement" with the proper type: FAIL
    HTMLVideoElement interface: video must inherit property "disablePictureInPicture" with the proper type: FAIL
    HTMLVideoElement interface: video must inherit property "onenterpictureinpicture" with the proper type: FAIL
    HTMLVideoElement interface: video must inherit property "onleavepictureinpicture" with the proper type: FAIL
    HTMLVideoElement interface: video must inherit property "requestPictureInPicture()" with the proper type: FAIL
    PictureInPictureWindow interface: pipw must inherit property "height" with the proper type: FAIL
    PictureInPictureWindow interface: pipw must inherit property "onresize" with the proper type: FAIL
    PictureInPictureWindow interface: pipw must inherit property "width" with the proper type: FAIL
    PictureInPictureWindow must be primary interface of pipw: FAIL
    Stringification of pipw: FAIL
/picture-in-picture/request-picture-in-picture-twice.html
    request Picture-in-Picture consumes user gesture: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1074242ec9b3
[wpt PR 12115] - Clean up picture-in-picture tests, a=testonly
https://hg.mozilla.org/mozilla-central/rev/1074242ec9b3
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.