Closed
Bug 1477538
Opened 6 years ago
Closed 6 years ago
When mail.autoComplete.commentColumn is set to 1, mailing list address autocomplete doesn't show the e-mail address but the address book
Categories
(MailNews Core :: Address Book, enhancement)
Tracking
(thunderbird_esr60 fixed, thunderbird62 wontfix, thunderbird63 fixed)
RESOLVED
FIXED
Thunderbird 63.0
People
(Reporter: jorgk-bmo, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
5.79 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
3.37 KB,
patch
|
jorgk-bmo
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1477503 +++ In bug 1439172 we implemented some magic to make use of that pref, but we forgot the entry of addresses into a mailing list. One can see the problem already in TB 60.
Flags: needinfo?(richard.marti)
Reporter | ||
Comment 1•6 years ago
|
||
Here's my patch for Windows only. But Richard told me that he also had a patch. I guess they will be identical ;-)
Flags: needinfo?(richard.marti)
Assignee | ||
Comment 2•6 years ago
|
||
Not identical. I move the rules to messenger.css to make them for all autocomplete popups that have messenger.css in their path. With this we don't need to duplicate the code on multiple files. Together with this I removed the .listcell-icon rules because they are not used. The comment says something about the attachments but here we don't use .listcell-icon.
Reporter | ||
Updated•6 years ago
|
Attachment #8994032 -
Attachment is obsolete: true
Reporter | ||
Comment 3•6 years ago
|
||
Ah yes, they are in mail/themes/shared/mail/messengercompose.css now. Well, when this first landed, there were three copies: https://hg.mozilla.org/comm-central/rev/b4e185898c1f
Assignee | ||
Comment 4•6 years ago
|
||
Three copies but one per platform. The shared messengercompose.css didn't exist then.
Reporter | ||
Comment 5•6 years ago
|
||
Comment on attachment 8994033 [details] [diff] [review] autocompleteLabels.patch Thanks, that works for me, also in the compose window. I haven't tried, but does this apply to ESR 60? I will do an ESR try run with this and some other stuff including bug 1477503.
Attachment #8994033 -
Flags: review?(jorgk)
Attachment #8994033 -
Flags: review+
Attachment #8994033 -
Flags: approval-comm-esr60+
Attachment #8994033 -
Flags: approval-comm-beta+
Reporter | ||
Comment 6•6 years ago
|
||
Hmm, for ESR 60 and beta we should leave the .listcell-icon since it's used in common/bindings/listbox.xml which we only killed some days ago, do you agree?
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/0ce2b2eefd46 Move the autocomplete label rules to messenger.css to apply to all autocomplete popups. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 63.0
Assignee | ||
Comment 8•6 years ago
|
||
Something like this for ESR?
Reporter | ||
Updated•6 years ago
|
Attachment #8994033 -
Flags: approval-comm-esr60+
Attachment #8994033 -
Flags: approval-comm-beta+
Reporter | ||
Comment 9•6 years ago
|
||
Comment on attachment 8994042 [details] [diff] [review] autocompleteLabels-esr.patch And beta, too, right? Try run coming up in a minute or two (or three ;-)).
Attachment #8994042 -
Flags: approval-comm-esr60+
Attachment #8994042 -
Flags: approval-comm-beta+
Reporter | ||
Comment 10•6 years ago
|
||
TB 60 ESR: https://hg.mozilla.org/releases/comm-esr60/rev/d8ccaf2c9c849b7d547c9a9aa3b03b77428f7692
status-thunderbird62:
--- → affected
status-thunderbird63:
--- → fixed
status-thunderbird_esr60:
--- → fixed
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Attachment #8994042 -
Flags: approval-comm-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•