Closed Bug 1477538 Opened 3 years ago Closed 3 years ago

When mail.autoComplete.commentColumn is set to 1, mailing list address autocomplete doesn't show the e-mail address but the address book

Categories

(MailNews Core :: Address Book, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird_esr60 fixed, thunderbird62 wontfix, thunderbird63 fixed)

RESOLVED FIXED
Thunderbird 63.0
Tracking Status
thunderbird_esr60 --- fixed
thunderbird62 --- wontfix
thunderbird63 --- fixed

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1477503 +++

In bug 1439172 we implemented some magic to make use of that pref, but we forgot the entry of addresses into a mailing list.

One can see the problem already in TB 60.
Flags: needinfo?(richard.marti)
No longer depends on: 1477503
Attached patch 1477538-commentColumn.patch (obsolete) — Splinter Review
Here's my patch for Windows only. But Richard told me that he also had a patch. I guess they will be identical ;-)
Flags: needinfo?(richard.marti)
Not identical. I move the rules to messenger.css to make them for all autocomplete popups that have messenger.css in their path. With this we don't need to duplicate the code on multiple files.

Together with this I removed the .listcell-icon rules because they are not used. The comment says something about the attachments but here we don't use .listcell-icon.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8994033 - Flags: review?(jorgk)
Attachment #8994032 - Attachment is obsolete: true
Ah yes, they are in mail/themes/shared/mail/messengercompose.css now. Well, when this first landed, there were three copies:
https://hg.mozilla.org/comm-central/rev/b4e185898c1f
Three copies but one per platform. The shared messengercompose.css didn't exist then.
Comment on attachment 8994033 [details] [diff] [review]
autocompleteLabels.patch

Thanks, that works for me, also in the compose window.

I haven't tried, but does this apply to ESR 60? I will do an ESR try run with this and some other stuff including bug 1477503.
Attachment #8994033 - Flags: review?(jorgk)
Attachment #8994033 - Flags: review+
Attachment #8994033 - Flags: approval-comm-esr60+
Attachment #8994033 - Flags: approval-comm-beta+
Hmm, for ESR 60 and beta we should leave the .listcell-icon since it's used in common/bindings/listbox.xml which we only killed some days ago, do you agree?
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0ce2b2eefd46
Move the autocomplete label rules to messenger.css to apply to all autocomplete popups. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
Something like this for ESR?
Attachment #8994033 - Flags: approval-comm-esr60+
Attachment #8994033 - Flags: approval-comm-beta+
Comment on attachment 8994042 [details] [diff] [review]
autocompleteLabels-esr.patch

And beta, too, right? Try run coming up in a minute or two (or three ;-)).
Attachment #8994042 - Flags: approval-comm-esr60+
Attachment #8994042 - Flags: approval-comm-beta+
Attachment #8994042 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.