1477539 - Clearing all history does not reset zoom setting of sites since FF62

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[Jason Mechelynck]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180721220720

Steps to reproduce:

Open any site including this page,

increase or decrease zoom size of the page.

clear all history -everything 


Actual results:

zoom setting is retained


Expected results:

Like before everything should have been reset to defaults

Comment 1

[Jason Mechelynck]

Bug 1473275
 

might have caused this regression

Comment 2

[Gingerbread Man]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ee1e13b5033892b805946ab20b42b7ea0a0b9aea&tochange=4f9eec6361279d8657ffc4e6ef5c84e8f5d08c56

Yes, this peculiar regression range from mozregression-gui is correct. I double-checked by manually testing the "first release with" and "last release without" builds.

https://archive.mozilla.org/pub/firefox/nightly/2018/06/2018-06-02-23-33-06-mozilla-central/
https://archive.mozilla.org/pub/firefox/nightly/2018/06/2018-06-01-10-01-02-mozilla-central/

Comment 3

[Gingerbread Man]

(In reply to Gingerbread Man from comment #2)
> Yes, this peculiar regression range from mozregression-gui is correct.

Sorry about the noise. That range is actually incorrect. Bug 1477781 filed to investigate what went wrong there.

If I select the last good build in mozregression-gui, that push log link includes bug 1422365, which is bound to be it.

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8c926373039374cd1a47d92215e9efb4d5557983&tochange=1f62ecdf59b6ecaa3c0fdda39bb296ec092a156b

> I double-checked by manually testing the "first release with" and "last
> release without" builds.

Those were nightly builds and therefore don't pinpoint a single bug.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: pref.patch

Comment 5

[:Gijs (he/him)]

Comment on attachment 8994764 [details] [diff] [review]
pref.patch

Review of attachment 8994764 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing, r=me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61f9854c9a74
Sanitizer.jsm must cleanup content preferences, r=Gijs

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/61f9854c9a74

Comment 8

[:Gijs (he/him)]

Comment on attachment 8994764 [details] [diff] [review]
pref.patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1422365
[User impact if declined]: clear recent history doesn't work as designed/expected
[Is this code covered by automated tests?]: there are some tests, but it looks like they're not sufficient to have caught this in automation...
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: yes, see comment 0
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: 1-line change fixing a simple typo
[String changes made/needed]: no

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8994764 [details] [diff] [review]
pref.patch

Recent regression, low-risk, Beta62+

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/953f3ace7cf4

Comment 11

[Adrian Florinescu [:aflorinescu]]

Reproduced the issue on an affected build: 62.0b10/20180719140244 - Windows 8.1 x64.

Verified as fixed on:
62.0b14 2018-08-02
63.0a1 	2018-08-05

using environments:
Windows 8.1 x64
Windows 10 x64
Osx 10.13
Ubuntu 16.04

Based on the above, marking this issue as verified fixed.