147755 - nsIAccessible's accName returns empty string instead of picking up label for XUL listbox node

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[dsirnapalli]

-- Test case attached. 
I am testing the below listbox. According to my thinking nsIAccessible accName
should pick up the label as the name of the listbox since i gave
control="get-item", but instead its showing null for name.

<label value="Select a List Item:" control="get-item"/>
<box orient="horizontal">
  <!-- listbox element is used to create multi-row list boxes -->
    <listbox id="get-item">
      <listitem label="First Item" value="firstitem"/>
      <listitem label="Second Item" value="seconditem"/>
      <listitem label="Third Item" value="thirditem"/>
      <listitem label="Fourth Item" value="fourthitem"/>
    </listbox>  
  <spacer flex="1"/>
</box>

Comment 1

[dsirnapalli]

Attachment: Testcase to reproduce the bug

Comment 2

[Kyle Yuan]

take it for me...

Comment 3

[Kyle Yuan]

Aaron, is there any specifications for what's the accName for each widget?
Should we return selected item's name there? On Windows, HTML list has no name 
and no value.

Where are the defines of control="xxx", such as <label value=".." control="get-
item"/> ?

Comment 4

[Aaron Leventhal]

Kyle, for XUL info I always go to www.xulplanet.com. They have an excellent
tutorial and reference there.

> control

> This attribute should be set to the id of an element that the label is 
> associated with. When the user clicks on the label, the associated element is 
> given the focus.

We should exactly exactly the same thing that IE exposes for listbox controls.

Comment 5

[Kyle Yuan]

Tested in Windows, neither accName nor accValue are not available for 
listbox/listview, no matter whether there is an item was selected.

Comment 6

[dsirnapalli]

Tested in Windows, neither accName nor accValue are not available for 
listbox/listview, no matter whether there is an item was selected.

-- It should atleast return null instead of ""(empty string). Usually this is
the behaviour is see with other elements.what do you say kyle.

Comment 7

[dsirnapalli]

-- It should atleast return null instead of ""(empty string). Usually this is
the behaviour is see with other elements.what do you say kyle.

Comment 8

[Kyle Yuan]

dharma, which element will return null for accName?

Comment 9

[dsirnapalli]

XUL Textbox

<description>
  <html:b> Testing XUL Textbox for Accessibility.. </html:b>
</description>
<box orient="vertical" flex="1">
  <!-- TextBox with default text -->
  <textbox value="Default text..."/>
  <spacer flex="1"/>
</box>

HTML CheckBox

document.write('<br><br><b> Testing Check Box </b><br><br>');
document.write('<form>');
document.write('Is your age: <br>');
document.write('<input type="checkbox" name="sex" onClick="nodeChecked();"
onFocus="nodeFocused();"> Above 30');
document.write('<input type="checkbox" name="sex"> Below 30');
document.write('</form>');

Comment 10

[dsirnapalli]

-- Kyle, i dont know whether it should return null or empty string. 
some elements are returning null and some elements are returning empty string.
For example the one's which are returning null is textbox for name.
the one's which is returning empty string is this list box itself.

Comment 11

[Kyle Yuan]

Maybe sometimes we forget to initialize the accName string to an empty string. 
But I think returning either null or empty string is no matter.
Aaron, what's your opinion?

Comment 12

[Aaron Leventhal]

I don't think null vs "" matters either.
By the way, nsAutoString always gets initialized to "" to start with.

Comment 13

[Kyle Yuan]

Dharma, as I and Aaron said, would you like to mark this bug "WONTFIX"?

Comment 14

[dsirnapalli]

-- Marking the bug as wontfix.

Comment 15

[dsirnapalli]

-- Marking the bug as verified.

Comment 16

[Kyle Yuan]

Suddenly I realized the test in comment 5 was based on IE's HTML document 
instead of the general UI elements. So I'd like to reopen and take it.

Comment 17

[Kyle Yuan]

Attachment: extract accName by calling GetXULAccName()

do the same work for colorpicker. IMO, we should get a name for every visible
widget. "Nameless" is helpless.

Comment 18

[Aaron Leventhal]

Comment on attachment 105943 [details] [diff] [review]
extract accName by calling GetXULAccName()

r=aaronl

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 105943 [details] [diff] [review]
extract accName by calling GetXULAccName()

Please use the request tracker instead of mailing me, ok?  ;)

Comment 20

[Kyle Yuan]

checked in!