1477578 - De-XPCOMify feed code

Status: RESOLVED WONTFIX

(Firefox Graveyard :: RSS Discovery and Preview, enhancement)

Description

[Kris Maglione [:kmag]]

For reasons that defy sense, the feed handling code is written using XPCOM gunk from top to bottom. Aside from using things like nsIArray and nsIPropertyBag rather than JS arrays and objects, it also registers a bunch of component factories, and uses those to construct its objects rather than just constructing the JS objects directly.

Aside from being terrible for performance, registering those factories is also terrible for memory usage.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1477578: De-XPCOMify feed handling code.

Review commit: https://reviewboard.mozilla.org/r/258612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258612/

Comment 2

[:Gijs (he/him)]

This is one of those cases where it would have been great to talk to me or Marco before writing this patch... We're about to rip the whole thing out (live bookmarks included). Given the long 63 timeline, I expect we'll do it for 63, though it might slip to 64. Should we close this as wontfix or is there some reason we should consider taking it and *then* ripping the whole thing out?

Comment 3

[Kris Maglione [:kmag]]

I knew it was going away, but I didn't realize the timeline was so short.

If it's going away, that works just as well for me. I only wasted an hour on it

Comment 4

[:Gijs (he/him)]

Comment on attachment 8994034 [details]
Bug 1477578: De-XPCOMify feed handling code.

https://reviewboard.mozilla.org/r/258612/#review265648

Clearing per bug resolution.