Closed Bug 1477616 Opened 7 years ago Closed 7 years ago

mach mozregression should allow option arguments to be passed to the application

Categories

(Testing :: mozregression, enhancement)

Product:
Testing
Component:
mozregression
Version:
Version 3
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: heycam, Unassigned)

Details

I want to use Firefox's Layout Debugger at each mozregression step. So I need to pass -layoutdebug to the Firefox binary. The -a argument to `mach mozregression` doesn't recognize a value after it if it looks like an option to be intepreted by the mozregression mach handler itself. Maybe `mach mozregression` can support a '--' argument and take all following values as argument passed to the application.
I really don't know much at all about mozregression's mach integration, or mach itself for that matter. :ahal, can you think of anything that does something like this already? https://searchfox.org/mozilla-central/source/tools/mach_commands.py#171 https://github.com/mozilla/mozregression/blob/master/mozregression/mach_interface.py
Flags: needinfo?(ahal)
It looks like the 'mach' command already does the right thing and re-uses mozregression's command line parser. So this change shouldn't need to touch the mach command at all (just add the arguments to mozregression and the mach command will pick it up when it picks up the new mozregression release).
Flags: needinfo?(ahal)
Note I'm not sure there'd be much utility in this specific case until bug 1467541 is fixed.
I think I misinterpreted the problem. Cameron, does |mach mozregression -a="-layoutdebug"| work? Using an = instead of a space normally solves these types of errors.
Flags: needinfo?(cam)
(In reply to Ian Moody [:Kwan] (UTC+0) from comment #3) > Note I'm not sure there'd be much utility in this specific case until bug > 1467541 is fixed. That's true. :( (In reply to Andrew Halberstadt [:ahal] from comment #4) > I think I misinterpreted the problem. Cameron, does |mach mozregression > -a="-layoutdebug"| work? Using an = instead of a space normally solves these > types of errors. It does! Don't know why I didn't think of trying that.
Flags: needinfo?(cam)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.