1477641 - Add-ons manager search field says 'search on addons.mozilla.org'

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Pascal Chevrel:pascalc]

Attachment: Capture d’écran de 2018-07-23 10-49-29.png

Thunderbird 60 preview
Built from https://hg.mozilla.org/releases/comm-esr60/rev/abae8941234801d8aa5b6cfd8cc49ef62bc48e62

The addons manager search placeholder says:
"Search on addons.mozilla.org"

instead of 
"Search on addons.thunderbird.net"

https://hg.mozilla.org/l10n/gecko-strings/file/default/toolkit/chrome/mozapps/extensions/extensions.dtd#l6

The string should either be updated in Toolkit with a variable for the site, or the string should be updated in Thunderbird files only.

See screenshot

Comment 1

[Jorg K (CEST = GMT+2)]

I have an idea.

Comment 2

[Jorg K (CEST = GMT+2)]

The string comes from here:
mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
6 <!ENTITY search.placeholder2  "Search on addons.mozilla.org">

And is used here:
mozilla/toolkit/mozapps/extensions/content/extensions.xul
255 placeholder="&search.placeholder2;" maxlength="100"/>

That's all M-C code. We have however code that tweaks that page, adding forward/backward arrows and modifying the context menu, so we can just substitute the string there.

"addons.mozilla.org" as such isn't localised anywhere:
https://dxr.mozilla.org/l10n-central/search?q=search.placeholder2&redirect=false
so straight string substitution will do the trick (I hope).

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1477641-amo-to-atn.patch

This JS code is very simple, you can review it ;-)

You can also check all the arguments in comment #2. This will work on all localised strings :-)

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1477641-amo-to-atn-esr60.patch

Same code applies to ESR 60.

Comment 5

[Jorg K (CEST = GMT+2)]

Try build together with bug 1478580:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=666b9d5f84b574db8a6de4737b6ee01e59950fe6

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8995612 [details] [diff] [review]
1477641-amo-to-atn.patch

This works, thanks.

Comment 7

[:aceman]

Comment on attachment 8995612 [details] [diff] [review]
1477641-amo-to-atn.patch

Review of attachment 8995612 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this works for me.
Assuming the box exists in all cases, whatever the Addon manager "tab" you have displayed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0fcc2b1f8a8
substitute addons.mozilla.org with addons.thunderbird.net on add-ons page. r=Paenglab,aceman

Comment 9

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #7)
> Assuming the box exists in all cases, whatever the Addon manager "tab" you
> have displayed.
Yes, I could have protected it with an |if (textbox) {|, but then it will silently fail when M-C changes the layout of the page. Perhaps better to see that malfunction, no?

Comment 10

[Jorg K (CEST = GMT+2)]

TB 60 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/bca85912a30b