Closed
Bug 1477688
Opened 6 years ago
Closed 6 years ago
Inadvertently enabled test_ext_contentScripts_register.js on Android
Categories
(WebExtensions :: General, enhancement, P3)
WebExtensions
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
Details
Attachments
(1 file)
In bug 1459404 I added a new test [test_ext_contexts_gc.js], but inadvertently put this before the skip-if exclusion rule that was meant to be associated with test_ext_contentScripts_register.js: https://searchfox.org/mozilla-central/diff/49d25fee18999891d026e5978fa4f8654de389e2/toolkit/components/extensions/test/xpcshell/xpcshell-content.ini#10-12 I'll let this inadvertent change stay for a week or two, and if there are no new intermittents (such as bug 1420594, where the skip-if was introduced), then I'll remove the skip-if condition. Otherwise I will move the skip-if up one line, to the intended location.
Comment 2•6 years ago
|
||
That skip-if should not be needed anymore, the underlying reasons for those failures should have been fixed by Bug 1423913 (See Bug 1422823 comment 5 and Bug 1422823 comment 6)
Updated•6 years ago
|
Priority: -- → P3
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd6d487c062a94bf233b9102b4e5160ac644712a Excerpt from X6: [task 2018-08-01T15:30:01.264Z] 15:30:01 INFO - TEST-START | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js [task 2018-08-01T15:30:22.623Z] 15:30:22 INFO - TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js | took 21360ms
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8996744 [details] Bug 1477688 - Enable test_ext_contexts_gc on Android https://reviewboard.mozilla.org/r/260792/#review268034
Attachment #8996744 -
Flags: review?(lgreco) → review+
Assignee | ||
Updated•6 years ago
|
Flags: qe-verify-
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/e811adca6e23 Enable test_ext_contexts_gc on Android r=rpl
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e811adca6e23
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•