1477703 - Calendar mozmill tests not run on Windows

Status: RESOLVED FIXED

(Calendar :: Build Config, enhancement)

Description

[Geoff Lankow (:darktrojan)]

The issue is here: https://hg.mozilla.org/comm-central/file/tip/mail/testsuite-targets.mk#l51 . The commands

> $(MAKE) -C $(commtopobjdir)/mail/test/mozmill stage-package

and 

> $(MAKE) -C $(commtopobjdir)/calendar/lightning stage-package

need to run in that order, but for some reason on Windows they're not. I suspect they're running in parallel, which is not good.

I can think of several ways to fix this, in fact I have a try run on which the tests run, but I'm sure anyone with a better Makefile knowledge would have a tidier solution.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Maybe you can discuss this with Rob when the two of you have time.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1477703-windows-mozmill-1.diff

This has been working for me on Try for a while now. I think I'm doing it right, but Makefiles are not my area of expertise.

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 8996636 [details] [diff] [review]
1477703-windows-mozmill-1.diff

Review of attachment 8996636 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I ran it through the try server myself, and everything passed.
As I'm new at this, perhaps someone else should take a quick look?

Comment 4

[Geoff Lankow (:darktrojan)]

We trust you, I think.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0653a55f913b
Specify packaging order so mozmill tests run on Windows. r=rjl