Closed Bug 1477703 Opened 2 years ago Closed 2 years ago

Calendar mozmill tests not run on Windows

Categories

(Calendar :: Build Config, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

The issue is here: https://hg.mozilla.org/comm-central/file/tip/mail/testsuite-targets.mk#l51 . The commands

> $(MAKE) -C $(commtopobjdir)/mail/test/mozmill stage-package

and 

> $(MAKE) -C $(commtopobjdir)/calendar/lightning stage-package

need to run in that order, but for some reason on Windows they're not. I suspect they're running in parallel, which is not good.

I can think of several ways to fix this, in fact I have a try run on which the tests run, but I'm sure anyone with a better Makefile knowledge would have a tidier solution.
Maybe you can discuss this with Rob when the two of you have time.
Flags: needinfo?(thunderbird)
This has been working for me on Try for a while now. I think I'm doing it right, but Makefiles are not my area of expertise.
Flags: needinfo?(rob)
Attachment #8996636 - Flags: review?(rob)
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Comment on attachment 8996636 [details] [diff] [review]
1477703-windows-mozmill-1.diff

Review of attachment 8996636 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. I ran it through the try server myself, and everything passed.
As I'm new at this, perhaps someone else should take a quick look?
Attachment #8996636 - Flags: review?(rob) → review+
We trust you, I think.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0653a55f913b
Specify packaging order so mozmill tests run on Windows. r=rjl
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
You need to log in before you can comment on or make changes to this bug.