Closed Bug 1477753 Opened Last year Closed Last year

sharedData listener causes leaks in parent process when not removed manually

Categories

(Core :: IPC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ntim, Assigned: kmag)

References

Details

Attachments

(1 file)

Blocks: 1474163
Blocks: 1463587
Assignee: nobody → kmaglione+bmo
Comment on attachment 8995369 [details]
Bug 1477753: Implement missing cycle collection hooks for SharedMap.

https://reviewboard.mozilla.org/r/259822/#review267060

::: dom/ipc/SharedMap.h:326
(Diff revision 1)
>  
>  class WritableSharedMap final : public SharedMap
>  {
>  public:
> +  NS_DECL_ISUPPORTS_INHERITED
> +  NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(WritableSharedMap, SharedMap)

Can this be NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED because you don't actually need to override the Trace() method?
Attachment #8995369 - Flags: review?(continuation) → review+
Comment on attachment 8995369 [details]
Bug 1477753: Implement missing cycle collection hooks for SharedMap.

https://reviewboard.mozilla.org/r/259822/#review267060

> Can this be NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED because you don't actually need to override the Trace() method?

I *think* so. I always forget the exact side-effects of that, so I tend to err on the safe side...
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/411056404d23
Implement missing cycle collection hooks for SharedMap. r=mccr8
https://hg.mozilla.org/mozilla-central/rev/411056404d23
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.