1477753 - sharedData listener causes leaks in parent process when not removed manually

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Tim Nguyen :ntim]

Example of leaks:
https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=f840add2cdd448ccb2a59d97c0ac6cbd967f038d&tochange=e207f210919a58c9032e3ea032ee1553194c8872&selectedJob=189514473&filter-searchStr=Linux%20x64%20asan%20Mochitests%20test-linux64-asan%2Fopt-mochitest-chrome-3%20M(c3)

From Kris on IRC:

We just don't clear the reference to the SharedMap early enough in the parent process

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1477753: Implement missing cycle collection hooks for SharedMap.

Review commit: https://reviewboard.mozilla.org/r/259822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259822/

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8995369 [details]
Bug 1477753: Implement missing cycle collection hooks for SharedMap.

https://reviewboard.mozilla.org/r/259822/#review267060

::: dom/ipc/SharedMap.h:326
(Diff revision 1)
>  
>  class WritableSharedMap final : public SharedMap
>  {
>  public:
> +  NS_DECL_ISUPPORTS_INHERITED
> +  NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(WritableSharedMap, SharedMap)

Can this be NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED because you don't actually need to override the Trace() method?

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8995369 [details]
Bug 1477753: Implement missing cycle collection hooks for SharedMap.

https://reviewboard.mozilla.org/r/259822/#review267060

> Can this be NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED because you don't actually need to override the Trace() method?

I *think* so. I always forget the exact side-effects of that, so I tend to err on the safe side...

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8995369 [details]
Bug 1477753: Implement missing cycle collection hooks for SharedMap.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259822/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/411056404d23
Implement missing cycle collection hooks for SharedMap. r=mccr8

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/411056404d23