1477862 - Menu items icons and texts are in separate lines when dev tools width is minimized

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[Abe - QA (:Abe_LV)]

Steps to reproduce:
Screen capture- https://testing-1.tinytake.com/sf/Mjc4NDUzMV84MzU1OTIw

1. Open dev-tools and minimize its width to the full. 
2. Click on chevron/meatballs door hanger menu 
3. Observe icons and texts

Expected result:
Text and icons should be in a single line

Actual result:
Menu item icons and texts are in separate lines.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

This cause is that we calculate the width of tooltip by adding the tooltip div element to the devtool's top document.[1] If this top document is narrow, the label of tooltip has a line break. So we can prevent this by adding white-space property into tooltip's label.

[1] https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/devtools/client/shared/widgets/tooltip/HTMLTooltip.js#674

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

WIP: https://treeherder.mozilla.org/#/jobs?repo=try&revision=998956826ae8bc46f295c57420464b0e09306bc4

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1477862 - Add white-space property into tooltip's label. r?birtles

If the width of the devtool window is narrow, tooltip's label has a line break.
This patch will prevent it.

Comment 4

[Phabricator Automation]

Comment on attachment 8996893 [details]
Bug 1477862 - Add white-space property into tooltip's label. r?birtles

Brian Birtles (:birtles) has approved the revision.

https://phabricator.services.mozilla.com/D2636

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41875a1f3b59
Add white-space property into tooltip's label. r=birtles

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/41875a1f3b59

Comment 7

[Abe - QA (:Abe_LV)]

I retested this on OSX 10.13, Windows 7, 10 and Ubuntu 16.04 with the latest Nightly.  Text and icon remain in the same line when the width of the devtool is minimized. It is verified as fixed.


One of the test env'ts
---------------------
Version 	63.0a1
Build ID 	20180814100100
Update Channel 	nightly
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0