Closed Bug 1477895 Opened 3 years ago Closed 1 month ago

Firefox wont suggest results from other tabs if history matches are disabled

Categories

(Firefox :: Address Bar, defect, P2)

61 Branch
defect
Points:
3

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- fixed

People

(Reporter: empathyblue, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Keywords: papercut, regression, Whiteboard: [fxsearch])

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704003137

Steps to reproduce:

go to 
1. options>privacy & security>address bar
2. untick "browsing history"
3 tick bookmarks
4 tick open tabs


Search in address bar for an open tab on yr current session.


Actual results:

Tabs open in current session are not suggested. only tabs from other devices are suggested


Expected results:

tabs from open on current device should be suggested to honor the preference setting.
Has STR: --- → yes
Component: Untriaged → Address Bar
I wonder if this is a regression... Anyway we should show switch to tab entries even if history results are disabled.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Whiteboard: [fxsearch]
Summary: Firefox wont suggest results from other tabs → Firefox wont suggest results from other tabs if history matches are disabled
Points: --- → 3

I suspect the problem here is that the query fetching history, bookmarks, switchtotab is the same, we probably filter on bookmark and history being disabled, maybe here
https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/toolkit/components/places/SQLFunctions.cpp#480-497

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Keywords: papercut
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Attachment #9239109 - Attachment description: Bug 1477895: Get the openpage data independently. → Bug 1477895: Get rid of WHERE condition of bookmark and history when openpage is enabled.
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/692ce94e3843
Get rid of WHERE condition of bookmark and history when openpage is enabled. r=adw
Attachment #9241048 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.