1477898 - Stop calling EditorBase::SetFlags() from nsTextEditorState as far as possible

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

EditorBase::SetFlags() usually appears when I test attachment 8848015 [details]. However, it does nothing while the test. So, it must be caused by the cost of virtual calls even though nsTextEditorState never handles HTMLEditor (HTMLEditor is the only one which overrides EditorBase::SetFlags()).

Fortunately, EditorBase::Flags() must be an inline method. So, nsTextEditorState can check if it should call SetFlags().

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1477898 - Make AutoRestoreEditorState not call EditorBase::SetFlags() since the virtual call cost appears in profile

Unfortunately, EditorBase::SetFlags() is virtual call even though
AutoRestoreEditorState always works only with TextEditor (the method is
overridden only by HTMLEditor).  And AutoRestoreEditorState is a hot path
when <input>.value or <textarea>.value is set a lot.

Fortunately, EditorBase::Flags() can be an inline method.  So, we can make
both constructor and destructor of the class check if it'll change flags
actually.

Additionally, this patch fixes nsTextEditorState::PrepareEditor() too.

Review commit: https://reviewboard.mozilla.org/r/258958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258958/

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8994391 [details]
Bug 1477898 - Make AutoRestoreEditorState not call EditorBase::SetFlags() since the virtual call cost appears in profile

https://reviewboard.mozilla.org/r/258958/#review266240

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d3ed6d8b874
Make AutoRestoreEditorState not call EditorBase::SetFlags() since the virtual call cost appears in profile r=m_kato

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4d3ed6d8b874