Closed
Bug 1477917
Opened 3 years ago
Closed 3 years ago
Clean up spellchecker XPCOM interfaces
Categories
(Core :: Spelling checker, enhancement)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(2 files)
- spellchecker's XPCOM interfaces have unused methods - spellchecker's XPCOM interfaces still use wstring. We should use AString instead.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
The language parameter of mozIPersonalDictionary is unused, so we should remove this from parameter. Then, no one uses mLanguage member of mozHunspell now.
|
||
Comment 3•3 years ago
|
||
Comment on attachment 8994735 [details] Bug 1477917 - Part 1. Remove unused methods for spellchecker. r=masayuki Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision. https://phabricator.services.mozilla.com/D2348
Attachment #8994735 -
Flags: review+
|
|
||
Comment 4•3 years ago
|
||
Comment on attachment 8994736 [details] Bug 1477917 - Part 2. Use AString instead of wstring in spellchecker. r?masayuki Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision. https://phabricator.services.mozilla.com/D2349
Attachment #8994736 -
Flags: review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/b7439662fa8f Part 1. Remove unused methods for spellchecker. r=masayuki
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/86df0a5cc49a Part 2. Use AString instead of wstring in spellchecker. r=masayuki
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b7439662fa8f https://hg.mozilla.org/mozilla-central/rev/86df0a5cc49a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•