Closed Bug 1477936 Opened 3 years ago Closed 1 year ago

Document node not highlighted in inspector from Accessibility tab

Categories

(DevTools :: Accessibility Tools, defect)

Product:
DevTools
Component:
Accessibility Tools
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox76 fixed)

Status:
VERIFIED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox76 --- fixed

People

(Reporter: cfogel, Assigned: yzen)

Details

Attachments

(2 files)

devtools_accesibilityInspectorNotHighlighted.gif
340.08 KB, image/gif
Details
Bug 1477936 - fixing document node highlighting in accessibility panel. r=mtigley
47 bytes, text/x-phabricator-request
Details | Review 
[Affected versions]:
-Firefox 61.0.1, 62.0b10, 63.0a1 (2018-07-23), 52.8.0esr, 60.0.2esr

[Affected platforms]:
- win 10x64, macOS 10.13.4, Ubuntu 16.04LTS

[Steps to reproduce]:
1. Launch Firefox;
2. Enable DevTools(F12 key) - Accessibility tab(F1 key,turn on the tool); 
3. Click on the Accessibility tab;
4. Click on the Turn on accessibility features button;
5. Click on the 1st item in the list (document:);
6. Click on the node select square for the DOMNode;

[Expected result]:
- the inspector tab is displayed and(probably)the document tag (<!DOCTYPE html>) is selected+highlighted

[Actual result]:
- either body or last inspected element is highlighted; the css properties sections are empty.


[Additional notes]:
- attached screen recording with the issue;
- the properties for the highlighted element are not displayed if clicked over, only when the element is re-inspected or another one selected and navigated back to the desired one in inspector;
- error message displayed in the console: TypeError: "container.editor is undefined";
No longer blocks: 1151468
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9bef02f44365
fixing document node highlighting in accessibility panel. r=mtigley
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f3aefb524279
fixing document node highlighting in accessibility panel. r=mtigley
Flags: needinfo?(yzenevich)

https://hg.mozilla.org/mozilla-central/rev/f3aefb524279

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
QA Whiteboard: [qa-76b-p2]
QA Contact: cristian.fogel

Marking as verified for the current release build(77.0.1) - confirmed on Windows 10, macOS 10.15.5, Ubuntu 18.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.