Closed
Bug 1477978
Opened 6 years ago
Closed 6 years ago
Make WPT session.end() swallow SessionNotCreatedException
Categories
(Remote Protocol :: Marionette, enhancement)
Remote Protocol
Marionette
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
1.48 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
See discussion in https://github.com/web-platform-tests/wpt/pull/12004 for more details.
Assignee | ||
Comment 1•6 years ago
|
||
Subsequent calls to session.end() should not result in SessionNotCreatedException being raised.
Attachment #8994478 -
Flags: review?(hskupin)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2761e07798f1f677b45b949b62d10ba82471d99a
Updated•6 years ago
|
Attachment #8994478 -
Flags: review?(hskupin) → review+
Comment 3•6 years ago
|
||
Will there be a way to stop the sync bug 1476131 from marking this test as expected fail? I mean when this patch lands before the expectation will be wrong again.
Blocks: 1476131
Flags: needinfo?(james)
Comment 4•6 years ago
|
||
We redo the metadata asap before landing, so if something changed in the meantime that marks the test as pass, we will get that right (unless we are unlucky and the change happens between the metadata update and the patch landing, but that's unavoidable).
Flags: needinfo?(james)
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/59ab6acdee53 Swallow SessionNotCreatedException on session.end(). r=whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12161 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/59ab6acdee53
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Upstream PR merged
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•