Closed Bug 1477978 Opened 6 years ago Closed 6 years ago

Make WPT session.end() swallow SessionNotCreatedException

Categories

(Remote Protocol :: Marionette, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

See discussion in https://github.com/web-platform-tests/wpt/pull/12004
for more details.
Subsequent calls to session.end() should not result in
SessionNotCreatedException being raised.
Attachment #8994478 - Flags: review?(hskupin)
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attachment #8994478 - Flags: review?(hskupin) → review+
Will there be a way to stop the sync bug 1476131 from marking this test as expected fail? I mean when this patch lands before the expectation will be wrong again.
Blocks: 1476131
Flags: needinfo?(james)
We redo the metadata asap before landing, so if something changed in the meantime that marks the test as pass, we will get that right (unless we are unlucky and the change happens between the metadata update and the patch landing, but that's unavoidable).
Flags: needinfo?(james)
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59ab6acdee53
Swallow SessionNotCreatedException on session.end(). r=whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12161 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/59ab6acdee53
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: