1477989 - Stop using js::GetGlobalForObjectCrossCompartment in XBL code

Status: RESOLVED FIXED

(Core :: XBL, enhancement)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Use JS::GetNonCCWObjectGlobal in nsXBLBinding::LookupMember

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Use JS::GetNonCCWObjectGlobal in nsXBLBinding::DoInitJSClass

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - Use JS::GetNonCCWObjectGlobal in nsXBLProtoImpl::InstallImplementation

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Part 4 - Use JS::GetNonCCWObjectGlobal in xpc::GetXBLScopeOrGlobal

GetOrCreateMapEntryForPrototype is the only caller where the object could be a CCW. However there cx and proto are same-compartment (GetOrCreateMapEntryForPrototype asserts this) so I changed that code to use JS::CurrentGlobalOrNull.

Comment 5

[Jan de Mooij [:jandem]]

This turned out to be easier than I expected and these patches are green on Try. But please review carefully.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8994586 [details] [diff] [review]
Part 2 - Use JS::GetNonCCWObjectGlobal in nsXBLBinding::DoInitJSClass

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8994587 [details] [diff] [review]
Part 3 - Use JS::GetNonCCWObjectGlobal in nsXBLProtoImpl::InstallImplementation

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8994588 [details] [diff] [review]
Part 4 - Use JS::GetNonCCWObjectGlobal in xpc::GetXBLScopeOrGlobal

r=me

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50a2d835fb1d
part 1 - Use JS::GetNonCCWObjectGlobal in nsXBLBinding::LookupMember. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cbf1712ac83
part 2 - Use JS::GetNonCCWObjectGlobal in nsXBLBinding::DoInitJSClass. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/96b793b536d0
part 3 - Use JS::GetNonCCWObjectGlobal in nsXBLProtoImpl::InstallImplementation. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/28325e1f71a4
part 4 - Use JS::GetNonCCWObjectGlobal in xpc::GetXBLScopeOrGlobal. r=bz

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/50a2d835fb1d
https://hg.mozilla.org/mozilla-central/rev/8cbf1712ac83
https://hg.mozilla.org/mozilla-central/rev/96b793b536d0
https://hg.mozilla.org/mozilla-central/rev/28325e1f71a4