1477990 - Phabricator can send stealth "you have a new review request" notifications that are easy to miss

Status: NEW

(Conduit :: Phabricator, enhancement, P5)

Description

[Boris Zbarsky [:bzbarsky]]

I got an email yesterday with this subject:

  [Differential] [Accepted] D1889: Bug 1472020: Make AccessibleCaret a bit saner. r=bz

The body of the email then says:

  TYLin added 1 blocking reviewer(s): bzbarsky.
  TYLin accepted this revision.
  TYLin added a comment.

and has the following stamps:

  actor(@TYLin) application(Differential) author(@emilio) blocking-reviewer(@bzbarsky) herald(H28) herald(H29) herald(H34) monogram(D1889) object-type(DREV) phid(PHID-DREV-rp2xr5oes7vjpvrwxlto) reviewer(@bzbarsky) reviewer(@TYLin) revision-repository(rMOZILLACENTRAL) revision-status(needs-review) subscriber(@TYLin) via(web)

Unfortunately, this doesn't match my mail search for differential review requests; the ones before this had had subjects like:

  [Differential] [Request] [+      ] D2311: Bug 1450164 - Don't update URIs on history adds on docshells that are being shut down; r=bz

so I was searching on "Request" but this string is not present anywhere in the mail I got yesterday.

The stamps don't help either, because those "blocking-reviewer(@bzbarsky)" and "reviewer(@bzbarsky)" stamps are on every single mail revision D1889 sends, including random comments by people and whatnot.

I guess what I'm looking for is clear state-transition emails, just like in bug 1474962.  But what Phabricator provides instead is current-state emails, as far as I can tell.