Closed Bug 1478016 Opened Last year Closed Last year

Make layers observer epoch strongly-typed

Categories

(Core :: Graphics: Layers, enhancement)

Other Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1448490 +++

We have a bajillion different uint64_t ids being passed around all over the codebase, and it's very easy to accidentally screw up which one you're passing where. I'd like to introduce a LayersObserverEpoch struct type that allows us to get better compile-time safety.
Comment on attachment 8994558 [details]
Bug 1478016 - Add a strongly-typed LayersObserverEpoch type.

https://reviewboard.mozilla.org/r/259108/#review267156
Attachment #8994558 - Flags: review?(matt.woodrow) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/383e6ae8f7d4
Add a strongly-typed LayersObserverEpoch type. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/383e6ae8f7d4
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.