Closed
Bug 1478020
Opened 6 years ago
Closed 6 years ago
Fix some -Wmicrosoft-template in the interceptor
Categories
(Core :: General, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
There are a few more -Wmicrosoft-template and -Wmicrosoft-cast scattered about the interceptor and MSCOM, but for now this will take out the vast majority of them.
Assignee: nobody → dmajor
Attachment #8994524 -
Flags: review?(aklotz)
To be specific, the warnings look like 13:59:51 INFO - z:/build/build/src/obj-firefox/dist/include/mozilla/interceptor/PatcherDetour.h(229,50): warning: use of identifier 'MMPolicyT' found via unqualified lookup into dependent bases of class templates is a Microsoft extension [-Wmicrosoft-template] 13:59:51 INFO - int CountModRmSib(const ReadOnlyTargetFunction<MMPolicyT>& aModRm,
|
||
Updated•6 years ago
|
OS: Unspecified → Windows
Priority: -- → P1
Hardware: Unspecified → All
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8994524 [details] [diff] [review] Bug 1478020 - Fix some -Wmicrosoft-template in the interceptor Review of attachment 8994524 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8994524 -
Flags: review?(aklotz) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/13baffe17d22 Fix some -Wmicrosoft-template in the interceptor. r=aklotz
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/13baffe17d22
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•