1478032 - Investigate the use of WOW64_64 when querying for maintenance service install

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P1)

Description

[Jim Mathies [:jimm]]

See the Microsoft list for full context.

--

Probably it’s below code which queries whether the maintenance service is installed, but it passes WOW64_64 flag which goes to native arm64 registry hive. The expecting key is actually written to WOW node by the installer. This also looks a problem for x86 on x64, but it doesn’t show up because x64 always prefer installing x64 Firefox instead of x86.

If so, I am wondering whether wrk.WOW64_64 is necessary here? Or we’ll need shim it for arm64.

https://github.com/mozilla/gecko-dev/blob/d0c49b92d2215448cd8e715bc1144fb2e8016350/browser/components/preferences/in-content/main.js#L524

Comment 1

[Jim Mathies [:jimm]]

Rob, would you mind poking through this to see what we can do here? Apparently we're having some trouble getting non-UAC updates working on the new ARM Win10 builds. There's a full discussion in the Microsoft list.

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attaching further detail to the bug:

It seems Firefox installer (like maintenanceservice_installer.exe) is written by some  macro language (see below snippet) which calls IsWow64Process and only passes KEY_WOW64_64KEY if IsWow64Process returns true. Which kind of make sense because KEY_WOW64_64KEY should only be used when running under WOW64. But we shim IsWow64Process and return false for x86 on arm64, so installer would write register data to WOW node. The problem is update.exe passes in KEY_WOW64_64KEY blindly as below code shows, which is expected to fail because registry data is installed to WOW node.  Probably update.exe should also check IsWow64Process because passing the flag, then it will be consistent with installer? 

https://github.com/mozilla/gecko-dev/blob/55f2b0d77abe8a4812849d924c75687a849fbf19/browser/installer/windows/nsis/stub.nsi#L349

  ${AndIf} ${RunningX64}

    SetRegView 64

    ${GetSingleInstallPath} "Software\Mozilla\${BrandFullNameInternal}" $R9

  ${EndIf}

Comment 3

[Robert Strong (they/them - no direct email)]

Looking

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b710bc3fc43e3f84c9e757dc29936926a6db5af

Comment 6

[Robert Strong (they/them - no direct email)]

I've manually verified this sets the registry values in the correct location

Comment 7

[Robert Strong (they/them - no direct email)]

The nightly build I am using was extracted from a mar file and the files in it are signed with the Mozilla fake certificate which prevents me from testing completely but I should be able to verify that the maintenance service is checking the correct keys, etc.

I filed bug 1514568 to get the files signed correctly.

Comment 8

[Robert Strong (they/them - no direct email)]

I've also been able to update using the maintenance service with the binary certificate checks disabled so the certificate checks should be all that is left to verify works correctly.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

I verified that the registry keys are checked by the maintenance service.

Clients won't be able to use the maintenance service to update until bug 1514568 is fixed.

Comment 10

[Robert Strong (they/them - no direct email)]

Per bug 1514568 comment #3

Once Bug 1514124 lands, and builds are being done on mozilla-central, the builds will be signed with the nightly cert.

Comment 11

[Robert Strong (they/them - no direct email)]

Asa, just an fyi since I know you've been trying out the builds.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d68a1c8025fb
Add aarch64 detection and set the correct registry views in the installer. r=mhowell

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d68a1c8025fb