1478048 - Long search terms break the Search bar from about:home and about:newtab

Status: NEW

(Firefox :: Search, defect, P5)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 63.0a1 (2018-07-23) 
- 62.0b11 build1 (20180723144101)
- 61.0.1 build1 (20180704003137)

[Affected platforms]:
- Windows 10 x64
- Ubuntu 18.04 x64
- macOS 10.13.4

[Steps to reproduce]:
1. Launch Firefox
2. Go to about:newtab (or about:home) 
3. Bring the Search bar in focus and type a very long term 
   - inspect the suggestions drop-down 
4. Clear the Search bar and populate it again in order to bring back the suggestions drop-down
   - inspect the suggestions drop-down 
5. Refresh the current tab
   - inspect the default search engine icon 
6. Click the Search button (with or without having the Search bar populated)

[Expected result]:
- [step3, step4] The search suggestions are properly displayed 
- [step5] The default search engine's icon is still displayed in the Search bar 
- [step6] The default search engine's page is successfully displayed (containing the search results for the inserted term, if necessary)

[Actual result]:
- [step4] The search suggestions drop-down is NOT displayed anymore 
- [step5] The default search engine icon is NOT displayed anymore in the Search bar 
- [step6] The Search bar becomes unresponsive
- see the following screencast for more details https://drive.google.com/file/d/1LNUJqUSEhNn5005-x8wbFRrwdEDUqonF/view?usp=sharing

[Regression range]:
- This isn't a recent regression, as it's reproducible all the way back to 53.0a1 (2017-01-01)

[Additional notes]:
- The following errors are triffered in Browser Console after step3:
SearchSuggestionController: HTTP Timeout SearchSuggestionController.jsm:336 
SearchSuggestionController: Non-200 status or empty HTTP response: 403 SearchSuggestionController.jsm:336

Comment 1

[Nihanth Subramanya [:nhnt11]]

This bug seems to highlight two issues: the missing max-width on the search suggestions dropdown table, which is dupe of bug 1186281, and an issue with the search suggestion controller that's resulting in a bad state.

I believe these two issues are separate, so I can't in good conscious resolve this as a dupe. I think adding bug 1186281 as "See Also" makes sense here, so there's nothing to be done.

Comment 2

[Nihanth Subramanya [:nhnt11]]

s/good conscious/good conscience/ of course :)