Closed Bug 1478067 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12160 - Ensure that `write_content` performs checks before writing

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12160 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12160
Details from upstream follow.

David Heiberg <dheiberg@mozilla.com> wrote:
>  Ensure that `write_content` performs checks before writing
>  
>  As mentioned in #11764, the python3 HTTP lib doesn't support simply writing HTTP body without writing status and headers. To help with this, I've changed the way `write_content` behaves by no longer blindly writing the data given to it, but instead performing checks to see if a status has been written and if required headers have been written (if at all needed). 
>  
>  I've moved the original behaviour of `write_content` to `write_raw_content` which blindly tries to write the data given to it to the `wfile`.
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f5d09634988
[wpt PR 12160] - Ensure that `write_content` performs checks before writing, a=testonly
https://hg.mozilla.org/mozilla-central/rev/9f5d09634988
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.