Closed Bug 1478070 Opened Last year Closed Last year

Too much time spent in DWriteFactory::CreateRenderingParamsInternal on www.jpro.one

Categories

(Core :: Graphics: WebRender, enhancement)

63 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jrmuizel, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We're spending a fair chunk of our blob drawing time here. It seems like we should be able to avoid that.

https://perfht.ml/2v59boi
Flags: needinfo?(lsalzman)
Maybe we're not hitting the font cache properly?
Blocks: 1450375
No attempt to be imaginative here. Just stashed the rendering params globally the same place they were already keeping the factory around.
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Flags: needinfo?(lsalzman)
Attachment #8994993 - Flags: review?(jmuizelaar)
Comment on attachment 8994993 [details] [diff] [review]
cache default DWrite rendering params in Skia

Review of attachment 8994993 [details] [diff] [review]:
-----------------------------------------------------------------

Any ideas why Chrome wouldn't need something like this?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8994993 [details] [diff] [review]
> cache default DWrite rendering params in Skia
> 
> Review of attachment 8994993 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Any ideas why Chrome wouldn't need something like this?

Because they don't use rendering params like we do. This was one of the changes Mason had to make to make our rendering match DWrite more closely, whereas Chrome simply does not care.
Attachment #8994993 - Flags: review?(jmuizelaar) → review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a88b894ab2f3
cache default DWrite rendering params in Skia. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/a88b894ab2f3
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Noticeable perf win on Windows 10 QR:


== Change summary for alert #14595 (as of Thu, 26 Jul 2018 00:29:29 GMT) ==

Improvements:

  4%  tsvgx windows10-64-qr opt e10s stylo     466.93 -> 447.70

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=14595
You need to log in before you can comment on or make changes to this bug.