Closed
Bug 1478070
Opened 6 years ago
Closed 6 years ago
Too much time spent in DWriteFactory::CreateRenderingParamsInternal on www.jpro.one
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: lsalzman)
References
Details
Attachments
(1 file)
|
4.89 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
We're spending a fair chunk of our blob drawing time here. It seems like we should be able to avoid that. https://perfht.ml/2v59boi
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(lsalzman)
|
|
Reporter | |
Comment 1•6 years ago
|
||
Maybe we're not hitting the font cache properly?
|
Assignee | |
Comment 2•6 years ago
|
||
No attempt to be imaginative here. Just stashed the rendering params globally the same place they were already keeping the factory around.
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Flags: needinfo?(lsalzman)
Attachment #8994993 -
Flags: review?(jmuizelaar)
|
|
Reporter | |
Comment 3•6 years ago
|
||
Comment on attachment 8994993 [details] [diff] [review] cache default DWrite rendering params in Skia Review of attachment 8994993 [details] [diff] [review]: ----------------------------------------------------------------- Any ideas why Chrome wouldn't need something like this?
|
|
Assignee | |
Comment 4•6 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3) > Comment on attachment 8994993 [details] [diff] [review] > cache default DWrite rendering params in Skia > > Review of attachment 8994993 [details] [diff] [review]: > ----------------------------------------------------------------- > > Any ideas why Chrome wouldn't need something like this? Because they don't use rendering params like we do. This was one of the changes Mason had to make to make our rendering match DWrite more closely, whereas Chrome simply does not care.
|
|
Reporter | |
Updated•6 years ago
|
Attachment #8994993 -
Flags: review?(jmuizelaar) → review+
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a88b894ab2f3 cache default DWrite rendering params in Skia. r=jrmuizel
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a88b894ab2f3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Comment 7•6 years ago
|
||
Noticeable perf win on Windows 10 QR: == Change summary for alert #14595 (as of Thu, 26 Jul 2018 00:29:29 GMT) == Improvements: 4% tsvgx windows10-64-qr opt e10s stylo 466.93 -> 447.70 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=14595
You need to log in
before you can comment on or make changes to this bug.
Description
•