Closed Bug 1478116 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12165 - Add inheritor as dep for includes

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12165 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12165
Details from upstream follow.

Luke Bjerring <lukebjerring@google.com> wrote:
>  Add inheritor as dep for includes
>  
>  This addresses an issue where, when testing a partial interface, we are not including the parents that implement said interface as dependencies.
>  
>  Specific example:
>  In `pointerevents`, we have `partial interface GlobalEventHandlers`
>  `Window includes GlobalEventHandlers`, but we do not include `Window` as an untested dep, so none of the members added in the partial are tested.
>  
>  To fix this, we treat both sides of `A includes B` as being deps.
>  I tested this in combination with #11922 locally, and the result was 129 tests (nearly double status quo).
PR 12165 applied with additional changes from upstream: 1d9eaf478433d0723efce46fb24618457cb75b1b, 4bb0586b21c65abfcf78afad408d7e2a04ab6bd0, cfeecd444046fc4e423f425ad87eba86a04c42f0, 67a2edf00ac1e65c6336d3f47638c73c339015d7, d8567389060ff683dbff2abff560a3fcbeebc064
PR 12165 applied with additional changes from upstream: 1d9eaf478433d0723efce46fb24618457cb75b1b, 4bb0586b21c65abfcf78afad408d7e2a04ab6bd0, cfeecd444046fc4e423f425ad87eba86a04c42f0, 13a85a4d1988b9b7b5998ae6b09cad60f2b63b21, 67a2edf00ac1e65c6336d3f47638c73c339015d7, d8567389060ff683dbff2abff560a3fcbeebc064
Ran 136 tests and 20650 subtests
OK     : 129
PASS   : 18348
FAIL   : 2302
TIMEOUT: 7

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/scroll-animations/idlharness.html
    Test scroll-animations IDL implementation: FAIL
/subresource-integrity/idlharness.window.html
    webappsec-subresource-integrity interfaces: FAIL

New tests that have failures or other problems:
/fetch/cors-rfc1918/idlharness.tentative.any.worker.html
    Document interface: document must not have property "addressSpace": FAIL
/mediacapture-record/idlharness.window.html
    BlobEvent interface object length: FAIL
    BlobEvent interface: [object BlobEvent] must inherit property "timecode" with the proper type: FAIL
    BlobEvent interface: attribute timecode: FAIL
    MediaRecorder interface: [object MediaRecorder] must inherit property "audioBitsPerSecond" with the proper type: FAIL
    MediaRecorder interface: [object MediaRecorder] must inherit property "onpause" with the proper type: FAIL
    MediaRecorder interface: [object MediaRecorder] must inherit property "onresume" with the proper type: FAIL
    MediaRecorder interface: [object MediaRecorder] must inherit property "videoBitsPerSecond" with the proper type: FAIL
    MediaRecorder interface: attribute audioBitsPerSecond: FAIL
    MediaRecorder interface: attribute onpause: FAIL
    MediaRecorder interface: attribute onresume: FAIL
    MediaRecorder interface: attribute videoBitsPerSecond: FAIL
    MediaRecorderErrorEvent interface: undefined must inherit property "error" with the proper type: FAIL
    MediaRecorderErrorEvent must be primary interface of undefined: FAIL
    Stringification of undefined: FAIL
/paint-timing/idlharness.window.html
    PerformancePaintTiming interface object length: FAIL
    PerformancePaintTiming interface object name: FAIL
    PerformancePaintTiming interface: existence and properties of interface object: FAIL
    PerformancePaintTiming interface: existence and properties of interface prototype object: FAIL
    PerformancePaintTiming interface: existence and properties of interface prototype object's "constructor" property: FAIL
    PerformancePaintTiming interface: existence and properties of interface prototype object's @@unscopables property: FAIL
    PerformancePaintTiming must be primary interface of paintTiming: FAIL
    Stringification of paintTiming: FAIL
    paint-timing interfaces.: FAIL
/picture-in-picture/idlharness.window.html
    ShadowRoot interface: attribute pictureInPictureElement: FAIL
/pointerlock/interfaces.window.html
    ShadowRoot interface: attribute pointerLockElement: FAIL
/webxr/interfaces.https.html
    WebGLRenderingContextBase interface: operation setCompatibleXRDevice(XRDevice): FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a694e4233c2a
[wpt PR 12165] - [idlharness.js] Add inheritor as dep for includes, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/973153d03ed4
[wpt PR 12165] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/a694e4233c2a
https://hg.mozilla.org/mozilla-central/rev/973153d03ed4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.