Closed Bug 1478146 Opened 6 years ago Closed 2 years ago

use SetFilePointerEx in nsLocalFileWin.cpp

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: froydnj, Assigned: barret)

Details

Attachments

(2 files)

We have moved on in our Windows support, and can now use SetFilePointerEx.
I think this works?
Attachment #8994665 - Flags: review?(aklotz)
Comment on attachment 8994665 [details] [diff] [review]
use SetFilePointerEx in nsLocalFileWin.cpp

Review of attachment 8994665 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8994665 - Flags: review?(aklotz) → review+

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:froydnj, could you have a look please?

Flags: needinfo?(nfroyd)
Flags: needinfo?(nfroyd)

The bug assignee didn't login in Bugzilla in the last 7 months.
:nika, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: froydnj+bz → nobody
Flags: needinfo?(nika)

This still seems to be a relevant & nice clean-up. :barret would you be interested in trying to land this cleanup?

Flags: needinfo?(nika) → needinfo?(brennie)
Assignee: nobody → brennie
Status: NEW → ASSIGNED
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02f90db1930a
Use SetFilePointerEx in nsLocalFileWin.cpp r=nika
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: