1478278 - [wpt-sync] Sync PR 12178 - Update ReadableStream to match standard

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12178 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12178
Details from upstream follow.

Adam Rice <[e-mail]> wrote:
>  Update ReadableStream to match standard
>  
>  Apply standard changes to ReadableStream up to standard version
>  51227372cc84846bdcf68312724c4cac6a4b9e58. With this change, Blink's
>  implementation once again passes all non-byte-stream ReadableStream
>  tests.
>  
>  Update test expectations to match.
>  
>  Changes:
>  
>  * Use null prototypes for the objects returned by
>    ReadableStreamDefaultReaderRead when they consumed internally by
>    pipeTo(), tee() or fetch. This is the fix for standard issue
>    https://github.com/whatwg/streams/issues/933 "Setting
>    Object.prototype.then permits interfering with pipeTo() internals".
>  * In pipeTo() complete all pending writes when readable stream is
>    errored.
>  * Change ordering of accessing strategy parameters to match standard.
>  
>  Non-user visible changes:
>  
>  * Use Object.assign() to be more concise when modifying the binding
>    object in ReadableStream.js and WritableStream.js.
>  
>  WPT changes:
>  
>  * Update the expectations in response-stream-with-broken-then.any.js
>    since interference is no longer possible.
>  * Add extra tests to response-stream-with-broken-then.any.js for the
>    arraybuffer -> text case which should have been broken in Chrome but
>    wasn't, and the arraybuffer -> stream case.
>  * Fix bugs in streams/piping/then-interception.js which are only
>    apparent when it passes. In particular, delete Object.prototype.then
>    even when it is not called.
>  
>  BUG=866388
>  
>  Change-Id: I82c8ac2c2b7d71ccbf331388014e8cec847e1b65
>  Reviewed-on: https://chromium-review.googlesource.com/1149678
>  WPT-Export-Revision: 9dac80f7e129532ff32e23d1fe19b66dd9700fbf

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=37c6177f4aa2ebe9b309a38ee47156780dccc66e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=530d138735dae7482b288c476cfc7d363d7a3499

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eded238243d0de0d18e6f8cd48c6b5975bd2771

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 6 tests and 21 subtests
OK     : 6
PASS   : 3
FAIL   : 18

New tests that have failures or other problems:
/fetch/api/response/response-stream-with-broken-then.any.html
    Attempt to inject 8.2 via Object.prototype.then.: FAIL
    Attempt to inject undefined via Object.prototype.then.: FAIL
    Attempt to inject value: undefined via Object.prototype.then.: FAIL
    Attempt to inject {done: false, value: bye} via Object.prototype.then.: FAIL
    intercepting arraybuffer to body readable stream conversion via Object.prototype.then should not be possible: FAIL
/fetch/api/response/response-stream-with-broken-then.any.worker.html
    Attempt to inject 8.2 via Object.prototype.then.: FAIL
    Attempt to inject undefined via Object.prototype.then.: FAIL
    Attempt to inject value: undefined via Object.prototype.then.: FAIL
    Attempt to inject {done: false, value: bye} via Object.prototype.then.: FAIL
    intercepting arraybuffer to body readable stream conversion via Object.prototype.then should not be possible: FAIL

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=106d97966fb17a2ba17395072f4e16db5c201166

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4fa68713e28
[wpt PR 12178] - Update ReadableStream to match standard, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/49eacc674968
[wpt PR 12178] - Update wpt metadata, a=testonly

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f4fa68713e28
https://hg.mozilla.org/mozilla-central/rev/49eacc674968