Closed Bug 1478333 Opened 6 years ago Closed 5 years ago

Text filter should affect executed commands and their results

Categories

(DevTools :: Console, defect, P3)

60 Branch
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: goddard, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180611123338

Steps to reproduce:

1. ctrl+shift+k
2. type 'navigator.userAgent', press 'enter'
3. click in filter output and type 'xxxx'


Actual results:

the result is not filtered


Expected results:

the result is filtered
Blocks: 1441085
Has STR: --- → yes
Component: Untriaged → Console
OS: Unspecified → All
Product: Firefox → DevTools
Hardware: Unspecified → All
Hello there, thanks for filing this issue

So, by design, we never filter: 
- inputs the user entered
- results of those inputs

This is why you still see them.
If you evaluate `console.log(navigator.userAgent)` however, filtering with "xxx" will hide the message, since it comes from the console API (which is probably what you use in your website to log things).

We did this because of 2 reason: 
- it would be too weird to hide sometime the input and not its result (think if you type `1+1` and then filter on `2`, you wouldn't know where it comes from).
- we are consistent with Chrome console behavior so users who use both tools have a consistent experience.

Now what we could do it apply the filter on both the input and its result, and if one of the 2 matches the filter, display them both.

Would this work for you ?
Priority: -- → P3
Summary: devtools filter results doesn't filter properly → Text filter should affect executed commands and their results
Status: UNCONFIRMED → NEW
Ever confirmed: true
thank you for the explanation, please feel free to close this bz.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.