Closed Bug 1478368 Opened 2 years ago Closed 2 years ago
[wdspec] Always use a window size of 800x600 by default
59 bytes, text/x-review-board-request
Right now the very first test after starting Firefox runs with the initial size. Then in `_restore_window_state` we set a size of 800x600, and keep it until Firefox is closed. Instead we should make sure to always run in 800x600 if this is our wanted size. As such the `session` fixture should set it before the first test starts.
Attachment #8995165 - Flags: review?(ato)
Comment on attachment 8995165 [details] Bug 1478368 - [wdspec] Use a default window size of 800x600. https://reviewboard.mozilla.org/r/259642/#review266680 ::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:22 (Diff revision 1) > > default_script_timeout = 30 > default_page_load_timeout = 300 > default_implicit_wait_timeout = 0 > > +default_window_size = (800, 600) Do we need to take device pixel ratio into account for Hi-DPI displays?
Attachment #8995165 - Flags: review?(ato) → review+
Comment on attachment 8995165 [details] Bug 1478368 - [wdspec] Use a default window size of 800x600. https://reviewboard.mozilla.org/r/259642/#review266680 > Do we need to take device pixel ratio into account for Hi-DPI > displays? You mean like the Retina displays from Apple? Then no, this is all managed by the browser/OS.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c5c4d8725e4f [wdspec] Use a default window size of 800x600. r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12207 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/12207 * continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/408881842?utm_source=github_status&utm_medium=notification)
I wish the sync bot would set these needinfos automatically.
Actually jgraham claims it is not a problem: https://github.com/web-platform-tests/wpt/pull/12207#issuecomment-408400705
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.