Closed Bug 1478368 Opened 2 years ago Closed 2 years ago

[wdspec] Always use a window size of 800x600 by default

Categories

(Testing :: geckodriver, enhancement, P2)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(1 file)

Right now the very first test after starting Firefox runs with the initial size. Then in `_restore_window_state` we set a size of 800x600, and keep it until Firefox is closed.

Instead we should make sure to always run in 800x600 if this is our wanted size. As such the `session` fixture should set it before the first test starts.
Attachment #8995165 - Flags: review?(ato)
Comment on attachment 8995165 [details]
Bug 1478368 - [wdspec] Use a default window size of 800x600.

https://reviewboard.mozilla.org/r/259642/#review266680

::: testing/web-platform/tests/webdriver/tests/support/fixtures.py:22
(Diff revision 1)
>  
>  default_script_timeout = 30
>  default_page_load_timeout = 300
>  default_implicit_wait_timeout = 0
>  
> +default_window_size = (800, 600)

Do we need to take device pixel ratio into account for Hi-DPI
displays?
Attachment #8995165 - Flags: review?(ato) → review+
Comment on attachment 8995165 [details]
Bug 1478368 - [wdspec] Use a default window size of 800x600.

https://reviewboard.mozilla.org/r/259642/#review266680

> Do we need to take device pixel ratio into account for Hi-DPI
> displays?

You mean like the Retina displays from Apple? Then no, this is all managed by the browser/OS.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5c4d8725e4f
[wdspec] Use a default window size of 800x600. r=ato
https://hg.mozilla.org/mozilla-central/rev/c5c4d8725e4f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12207 for changes under testing/web-platform/tests
I wish the sync bot would set these needinfos automatically.
Flags: needinfo?(hskupin)
Actually jgraham claims it is not a problem:
https://github.com/web-platform-tests/wpt/pull/12207#issuecomment-408400705
Flags: needinfo?(hskupin)
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.