Closed Bug 1478375 Opened 2 years ago Closed 1 year ago
Remove region argument in call to invoke
Drag Session and/or usage of invoke Drag Session
comm-central has only place where a manual call to invokeDragSession is done. Bug 1473029 removes the region argument from this method, and in the future, the method would be removed entirely. The drag region is assigned in calendar-dnd-listener.js . However, this will draw no drag feedback (only invokeDragSessionWithImage does this), so the region is not really used (except on Mac which draws an outline). However, testing shows that the drag feedback coordinates used in calendar-dnd-listener.js are wrong anyway, so the drag feedback is way off. In the absence of coverting this to use the drag and drop api (dataTransfer) instead of invokeDragSession, the one call can just remove the region argument and have no real noticeable effects.
This patch restores dragging based on Neils proposal.
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/834b5f6d29c4 Restore Dragging for Calendar: call invokeDragService without a region argument. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
TB 63 beta, Cal 6.5: https://hg.mozilla.org/releases/comm-beta/rev/3bf87423b8e4568bbf2aacdbb4aeb1bfdfd2841e
Target Milestone: 6.6 → 6.5
You need to log in before you can comment on or make changes to this bug.