Closed Bug 1478375 Opened 2 years ago Closed 1 year ago

Remove region argument in call to invokeDragSession and/or usage of invokeDragSession

Categories

(Calendar :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: MakeMyDay)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

comm-central has only place where a manual call to invokeDragSession is done.

Bug 1473029 removes the region argument from this method, and in the future, the method would be removed entirely.

The drag region is assigned in calendar-dnd-listener.js . However, this will draw no drag feedback (only invokeDragSessionWithImage does this), so the region is not really used (except on Mac which draws an outline). However, testing shows that the drag feedback coordinates used in calendar-dnd-listener.js are wrong anyway, so the drag feedback is way off.

In the absence of coverting this to use the drag and drop api (dataTransfer) instead of invokeDragSession, the one call can just remove the region argument and have no real noticeable effects.
Blocks: 1480039
This patch restores dragging based on Neils proposal.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Attachment #9009433 - Flags: review?(philipp)
Attachment #9009433 - Flags: approval-calendar-beta?(philipp)
Attachment #9009433 - Flags: review?(philipp)
Attachment #9009433 - Flags: review+
Attachment #9009433 - Flags: approval-calendar-beta?(philipp)
Attachment #9009433 - Flags: approval-calendar-beta+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/834b5f6d29c4
Restore Dragging for Calendar: call invokeDragService without a region argument. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.6
Depends on: 1496053
You need to log in before you can comment on or make changes to this bug.