Closed
Bug 1478385
Opened 4 years ago
Closed 4 years ago
Fix confussion in GetCachedWidgetBorder
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment 2•4 years ago
|
||
mozreview-review |
Comment on attachment 8994862 [details] Bug 1478385: Fix confusion in GetCachedWidgetBorder. https://reviewboard.mozilla.org/r/259404/#review266518 ::: commit-message-9abe7:5 (Diff revision 1) > +Bug 1478385: Fix confusion in GetCachedWidgetBorder. r?karlt > + > +aWidgetType is a NS_THEME_* constant. What this code is comparing is not. > + > +Is this comparison needed at all? Yes. I expect you are fixing a hard-to-reproduce bug for users with combinations of RTL and LTR pages.
Attachment #8994862 -
Flags: review?(karlt) → review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7ad6a70635a Fix confusion in GetCachedWidgetBorder. r=karlt
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a7ad6a70635a
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•