1478385 - Fix confussion in GetCachedWidgetBorder

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1478385: Fix confusion in GetCachedWidgetBorder.

aWidgetType is a NS_THEME_* constant. What this code is comparing is not.

Is this comparison needed at all?

This was exposed by a patch of mine converting -moz-appearance to be an enum
class.

Review commit: https://reviewboard.mozilla.org/r/259404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259404/

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8994862 [details]
Bug 1478385: Fix confusion in GetCachedWidgetBorder.

https://reviewboard.mozilla.org/r/259404/#review266518

::: commit-message-9abe7:5
(Diff revision 1)
> +Bug 1478385: Fix confusion in GetCachedWidgetBorder. r?karlt
> +
> +aWidgetType is a NS_THEME_* constant. What this code is comparing is not.
> +
> +Is this comparison needed at all?

Yes.  I expect you are fixing a hard-to-reproduce bug for users with combinations of RTL and LTR pages.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7ad6a70635a
Fix confusion in GetCachedWidgetBorder. r=karlt

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a7ad6a70635a