Closed Bug 1478404 Opened Last year Closed Last year

Remove all traces of _xpcom_categories

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

Details

Attachments

(2 files)

Pointed out by Florian in bug 1477670 - AFAICT bug 568691 ( https://hg.mozilla.org/mozilla-central/rev/b9a87d218a73 ) removed support for XPCOMUtils.generateModule, and ever since then the _xpcom_categories garbage has been a complete no-op. Kris, am I missing something? If not, we should nuke all remaining references ( https://searchfox.org/mozilla-central/search?q=_xpcom_categories ) from orbit.
Flags: needinfo?(kmaglione+bmo)
Yup, this has been dead code for years. And the in-tree references are... super dodgy. If the thing actually worked, we'd wind up with a "service" category entry named "true" with some random contract ID as its value depending on registration order...

So, yeah, nuke it.
Flags: needinfo?(kmaglione+bmo)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Support for the _xpcom_categories property was removed in Bug 568691,
but we left a bunch of consumers behind, and it's been cargo-culted a bit more.
We should remove the remaining remnants.
Comment on attachment 8995201 [details]
Bug 1478404 - remove _xpcom_categories annotations as they're dead code, r?florian

Florian Quèze [:florian] has approved the revision.

https://phabricator.services.mozilla.com/D2429
Attachment #8995201 - Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6499bc583b57
remove _xpcom_categories annotations as they're dead code, r=florian
https://hg.mozilla.org/mozilla-central/rev/6499bc583b57
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ce7ded0ac20f37f5a4d1e8c68664ca134e7faa77
chore(mc): Port Bug 1478404 - remove _xpcom_categories annotations as they're dead code, r=florian (#4280)
You need to log in before you can comment on or make changes to this bug.