Closed Bug 1478411 Opened Last year Closed Last year

Make DTD entity expansion in strings.xml surface errors when entities are missing

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P5)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Deep in the Android build system, we expand DTD entities while processing `strings.xml`.  The code is around https://searchfox.org/mozilla-central/rev/bdfd20ef30d521b57d5b6feeda71325e8b4cad66/mobile/android/app/build.gradle#280-293.

If there's a localization error, which seems to sometimes include a localization just not localizing an entity yet, the build system fails in an opaque fashion -- see Bug 1452589.

This ticket tracks identifying these interpolation errors and surfacing them with whatever tags the Tree Herder log parsing needs for the sheriffs to classify the errors correctly.  Maybe we can message the relevant locale and the specific entity that's malformed?
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
This is awkward but works locally (and should work in automation,
which also displays the "[Fatal Error]" strings).  The pattern was
taken from GeckoView's amplification of the Kotlin compilers output
warnings.
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/022f4e59d3ba
Make DTD entity expansion in strings.xml surface errors when entities are missing. r=jchen
https://hg.mozilla.org/mozilla-central/rev/022f4e59d3ba
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee: nobody → nalexander
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 64 → mozilla64
You need to log in before you can comment on or make changes to this bug.